WordPress.org
Get WordPress

Making WordPress.org

Opened 6 years ago

Closed 5 years ago

#4566 closed defect (bug) (fixed)

Image placeholder isn't size-constrained

Reported by: jonoaldersonwp's profile jonoaldersonwp Owned by:
Milestone: Priority: lowest
Component: WordCamp Site & Plugins Keywords: seo good-first-bug has-patch
Cc:

Description

When a WordCamp page is missing an image, such as with ​https://central.wordcamp.org/wordcamps/wordcamp-grand-rapids/, the preview/loading image escapes its bounding.

Attachments (1)

4566.diff​ (588 bytes) - added by donmhico 5 years ago.

Download all attachments as: .zip

Change History (4)

#1 @iandunn
6 years ago

  • Keywords needs-patch good-first-bug added
  • Status changed from new to assigned

+1

@donmhico
5 years ago

#2 @donmhico
5 years ago

  • Keywords has-patch added; needs-patch removed

Basically in my patch, 4566.diff, I just added width: inherit; since it's immediate parent DOM which is .wc-single-website has set width width: 220px;. So in the future if the width is ever to be changed, the only place needed to be changed is width in .wc-single-website and the preview image will always adapt.

#3 @ryelle
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in ​8858745. Thanks for the patch, @donmhico !

Note: See TracTickets for help on using tickets.