Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#4609 closed enhancement (fixed)

Please introduce a 'needs-copy-review' Workflow keyword

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Priority: normal
Component: Trac Keywords: has-patch needs-testing



Many contributors have been using the 'needs-copy-review' keyword by manually adding it, see Trac report;

And raising in Slack got a few (+) so am requesting it be added as an official keyword.

Following the existing definitions -

Proposed definition;
A review is requested from a copywriter with regards to the strings and verbiage being used.

And should probably also add a 'has-copy-review' tag to follow the other conventions with the definition of:
A review has been given from a copywriter with regards to the strings and verbiage being used.

This would allow developers to flag strings and verbiage to copywriter contributors so they may conduct a review and indicate any verbiage concerns or supply suggested content.

Thank you

Attachments (1)

4609.diff (1.5 KB) - added by garrett-eclipse 5 years ago.
Initial implementation

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in Slack in #core by garrett-eclipse. View the logs.

5 years ago

5 years ago

Initial implementation

#2 @garrett-eclipse
5 years ago

  • Keywords has-patch needs-testing added

I've uploaded an initial patch 4609.diff for this.
The verbiage used for the keyword definitions;

'has-copy-review' : 'Input has been given from a copywriter reviewing the suggested verbiage changes.',
'needs-copy-review' : 'Input is needed from a copywriter with regards to the suggested verbiage changes.',

*This is based on the needs-privacy-review keyword

#3 @garrett-eclipse
5 years ago

Please note that when committed the Trac Workflow Keywords definitions linked below will need to be updated.

#4 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 9053:

Trac: Add has-copy-review and needs-copy-review keywords.

Props garrett-eclipse.
Fixes #4609.

#6 @SergeyBiryukov
5 years ago

In 9054:

Trac: Bump scripts version after [9053].

See #4609.

#7 @garrett-eclipse
5 years ago

Thanks @SergeyBiryukov I've also updated the documentation;

Note: See TracTickets for help on using tickets.