Making WordPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#4610 closed enhancement (fixed)

Introduce 'copy' or 'strings' or 'verbiage' as a Trac focus

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Trac Keywords: has-patch
Cc:

Description

Hello,

Along with #4609 I'm opening this due to the discussion on slack;
@clorith - "I view strings as a focus within each component, not as a component of them selves"
Reference - https://wordpress.slack.com/archives/C02RQBWTW/p1563396887461100

I tend to agree it shouldn't be a component but more a focus. Raising for discussion.

Thanks

Attachments (1)

4610.diff (584 bytes) - added by garrett-eclipse 6 years ago.
Patch to introduce a ui-copy focus

Download all attachments as: .zip

Change History (8)

@garrett-eclipse
6 years ago

Patch to introduce a ui-copy focus

#1 @garrett-eclipse
6 years ago

  • Keywords has-patch needs-testing added

I've supplied an initial patch to introduce a new ui-copy focus in 4610.diff.;
'ui-copy' : 'Copy focus for the user interface.',

I'm unsure if there needs to be anything else edited for the new focus, with new keywords I had to update this page;
https://make.wordpress.org/core/handbook/contribute/trac/keywords/
*Should there be a documented page outlining the Focuses?

Or if the reports like this are automatically generated;
https://core.trac.wordpress.org/focus/accessibility

#2 @tellyworth
6 years ago

  • Owner set to dd32
  • Status changed from new to assigned

#3 @dd32
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 9076:

Trac: Add 'ui-copy' as a focus.

Props garrett-eclipse.
Fixes #4610.

#4 @dd32
6 years ago

In 9077:

Trac: Bump scripts version after [9076].

See #4610.

#5 @dd32
6 years ago

  • Keywords needs-testing removed

I think that's all that actually needs doing here, let's see what happens shall we?

#6 @garrett-eclipse
6 years ago

Thanks @dd32 much appreciated

#7 @SergeyBiryukov
5 years ago

In 9353:

Trac: Notifications: Add css and ui-copy focuses to Trac Notifications settings page.

Props noisysocks.
See #4844, #4610.

Note: See TracTickets for help on using tickets.