WordPress.org
Get WordPress

Making WordPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#466 closed enhancement (fixed)

Cannot click filename on uploaded patch

Reported by: atimmer's profile atimmer Owned by: nacin's profile nacin
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

For example: ​https://core.trac.wordpress.org/attachment/ticket/25698/25698.2.diff

You cannot click on the filename to get to the file.

Change History (5)

#1 @Otto42
10 years ago

As far as I know, that's never been possible for a patch file. The name of the file being an anchor tag is there mainly for looks and because it's using the same sort of viewer as the normal source code viewer.

The patch viewer isn't actually pointing to a file in source control, it's just displaying the contents of the patch in a more readable way.

#2 @atimmer
10 years ago

  • Type changed from defect to enhancement

You are right, it is meant as an improvement.

#3 @atimmer
10 years ago

#675 was marked as a duplicate.

#4 @nacin
10 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 1069:

Trac: Don't show filenames in diff previews as links. (These are <a> without href.)

fixes #466.

#5 @nacin
10 years ago

I'll deploy these CSS changes soon-ish.

Note: See TracTickets for help on using tickets.