Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#4706 closed enhancement (fixed)

Remove 'blogroll' from the import options

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: API Keywords:
Cc:

Description

Background: #WP22994 for the change in WordPress core.

Since we've removed Link Manager from core 7 years ago (#WP21307), we should not encourage importing links.

This will require a change to https://api.wordpress.org/core/importers/1.1/, and maybe bumping the API version, so it does not affect the earlier WordPress versions.

Change History (7)

#1 follow-up: @SergeyBiryukov
5 years ago

and maybe bumping the API version, so it does not affect the earlier WordPress versions

Looks like that's not necessary, as the endpoint receives the version number, see [3690].

#2 in reply to: ↑ 1 ; follow-up: @Hareesh Pillai
5 years ago

  • Keywords reporter-feedback added

Replying to SergeyBiryukov:

and maybe bumping the API version, so it does not affect the earlier WordPress versions

Looks like that's not necessary, as the endpoint receives the version number, see [3690].

In that case, is the related ticket WP 22994 good to commit?

#3 in reply to: ↑ 2 @SergeyBiryukov
5 years ago

  • Keywords reporter-feedback removed

Replying to Hareesh Pillai:

In that case, is the related ticket WP 22994 good to commit?

Bumping the API version should not be necessary, but we'd still need to add some logic to the API to exclude "Blogroll" for WordPress 5.3+.

This ticket was mentioned in Slack in #core by hareesh-pillai. View the logs.


5 years ago

#5 @dd32
5 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9158:

API: Core Importer List: Drop the 'Blogroll' importer from recommendations.

Props Hareesh Pillai.
Fixes #4706.

#6 @dd32
5 years ago

Just noting I'd not seen the Core ticket was bumped out of 5.3 - Awaiting feedback on the core ticket, we can bump this to 5.4+ or punt it forever again if needed.

For now, Blogroll won't show up in the 5.3 beta's.

#7 @SergeyBiryukov
5 years ago

In 9480:

API: Core Importer List: Drop the 'Blogroll' importer from recommendations for WordPress 5.4+.

Follow-up to [9158] to match the core change in [WP47227].

See #4706.

Note: See TracTickets for help on using tickets.