WordPress.org

Making WordPress.org

Changes between Initial Version and Version 1 of Ticket #470, comment 2


Ignore:
Timestamp:
12/31/2014 09:05:20 AM (5 years ago)
Author:
bansod_deven
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #470, comment 2

    initial v1  
    11I went through the MeetUp API request we are making to get the MeetUp Events in the function 'get_meetup_events()' on line 117.
    22
    3 In MeetUp API request, I guess we can remove 'page' argument and we will be done.
     3In MeetUp API request, I guess we can remove 'page' argument and we will be done but I am not sure as I could not find any default value for 'page' argument on MeetUp Documentation.
     4 
     5I could not find a specific MAX Value allowed for 'page' either but a forum on drupal.org mentions that max value is 200 and if we put 'page=0' it automatically changes to 'page=200'.
     6
     7Forum Link : https://www.drupal.org/node/949246
    48
    59But how do we add an option to change between some constant Results and Infinite Results ?
    610
    7 What I had in mind was we can check if the 'POSTS_PER_PAGE' constant value in 'official_wordpress_events.php' is '-1' then we can assume infinite scrolling and if its a postive integer then we can take that value.
     11What I had in mind was we can check if the 'POSTS_PER_PAGE' constant value in 'official_wordpress_events.php' is '0' then it will automatically change it to '200' according to the mentioned Forum Posts.
    812
    913
    10 Suggest changes and I will then add the patch accordingly.
     14
     15And regarding the WordCamp events, there is no such upper limit mentioned in this code.
     16
     17
     18Please suggest changes and I will then add the patch accordingly.