Plugin Directory: Permanent closure check not correct

[Ipstenu]

Probably my bad there but #4694 is not properly showing when a plugin is perma-closed.

This should get it.

[SergeyBiryukov]

Does 4718.diff​ have all the changes? I only see text adjustments and adding github- to the list of trademarked slugs, no changes to permanent closure check.

[Ipstenu]

Nope because I uploaded the wrong file.

See 4718-2.diff

[SergeyBiryukov]

Unless I'm missing something, 4718-2.diff​ is equivalent to the current code, just more verbose.

Looking at a couple of random recently closed plugins, they do display the "closure is permanent" notice:

• ​https://wordpress.org/plugins/wootix/
• ​https://wordpress.org/plugins/woo-bacs-recipts/

Is there a plugin where the current check doesn't work as expected?

[Ipstenu]

It's not doing it on plugins that have no committers. So $contributors = get_the_terms( $post, 'plugin_contributors' ); isn't working as expected. I'll try to find another example, but of course looking for no-committers is hard.

[SergeyBiryukov]

Replying to Ipstenu:

It's not doing it on plugins that have no committers. So $contributors = get_the_terms( $post, 'plugin_contributors' ); isn't working as expected.

Thanks for the clarification!

1. Should we check for both committers and contributors there, or just committers? Looking at some of the recently closed plugins with no committers, they all appear to retain their list of contributors, so probably the latter (only committers should be checked)?
2. Are the text changes from 4718.diff​ ready for commit too?

[SergeyBiryukov]

In 9128:

Plugin Directory Theme: When determining the permanence of plugin closure, check if the plugin has committers.

Props Ipstenu.
See #4718, #4694.

[SergeyBiryukov]

In 9129:

Plugin Directory Theme: Correct the close reason check when determining the permanence of plugin closure.

See #4718, #4694.

[Ipstenu]

Should we check for both committers and contributors there, or just committers?

Just committers. Contrib are pulled from the readme, so we couldn't edit that without editing the code. committers are post-type meta, so when we wipe that it revokes practical access.

Are the text changes from 4718.diff​ ready for commit too?

Yes.

[SergeyBiryukov]

In 9130:

Plugin Directory: Upload: Improve upload error messages.

Clarify that reviews are currently in English only.

Update the list of trademarked slugs.

Props Ipstenu.
Fixes #4718. See #4704.