WordPress.org

Making WordPress.org

Opened 2 weeks ago

Closed 12 days ago

#4718 closed defect (fixed)

Plugin Directory: Permanent closure check not correct

Reported by: Ipstenu Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

Probably my bad there but #4694 is not properly showing when a plugin is perma-closed.

This should get it.

Attachments (2)

4718.diff (4.9 KB) - added by Ipstenu 2 weeks ago.
4718-2.diff (872 bytes) - added by Ipstenu 2 weeks ago.

Download all attachments as: .zip

Change History (12)

@Ipstenu
2 weeks ago

#1 @SergeyBiryukov
2 weeks ago

  • Component changed from General to Plugin Directory
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @SergeyBiryukov
2 weeks ago

Does 4718.diff have all the changes? I only see text adjustments and adding github- to the list of trademarked slugs, no changes to permanent closure check.

@Ipstenu
2 weeks ago

#3 @Ipstenu
2 weeks ago

Nope because I uploaded the wrong file.

See 4718-2.diff

#4 @SergeyBiryukov
2 weeks ago

Unless I'm missing something, 4718-2.diff is equivalent to the current code, just more verbose.

Looking at a couple of random recently closed plugins, they do display the "closure is permanent" notice:

Is there a plugin where the current check doesn't work as expected?

#5 follow-up: @Ipstenu
2 weeks ago

It's not doing it on plugins that have no committers. So $contributors = get_the_terms( $post, 'plugin_contributors' ); isn't working as expected. I'll try to find another example, but of course looking for no-committers is hard.

#6 in reply to: ↑ 5 @SergeyBiryukov
13 days ago

Replying to Ipstenu:

It's not doing it on plugins that have no committers. So $contributors = get_the_terms( $post, 'plugin_contributors' ); isn't working as expected.

Thanks for the clarification!

  1. Should we check for both committers and contributors there, or just committers? Looking at some of the recently closed plugins with no committers, they all appear to retain their list of contributors, so probably the latter (only committers should be checked)?
  2. Are the text changes from 4718.diff ready for commit too?

#7 @SergeyBiryukov
13 days ago

In 9128:

Plugin Directory Theme: When determining the permanence of plugin closure, check if the plugin has committers.

Props Ipstenu.
See #4718, #4694.

#8 @SergeyBiryukov
13 days ago

In 9129:

Plugin Directory Theme: Correct the close reason check when determining the permanence of plugin closure.

See #4718, #4694.

#9 @Ipstenu
12 days ago

Should we check for both committers and contributors there, or just committers?

Just committers. Contrib are pulled from the readme, so we couldn't edit that without editing the code. committers are post-type meta, so when we wipe that it revokes practical access.

Are the text changes from 4718.diff​ ready for commit too?

Yes.

#10 @SergeyBiryukov
12 days ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 9130:

Plugin Directory: Upload: Improve upload error messages.

Clarify that reviews are currently in English only.

Update the list of trademarked slugs.

Props Ipstenu.
Fixes #4718. See #4704.

Note: See TracTickets for help on using tickets.