WordPress.org

Making WordPress.org

Opened 10 months ago

Closed 3 months ago

Last modified 3 months ago

#4721 closed defect (fixed)

Alignment issue on individual theme's page

Reported by: krupajnanda Owned by: dd32
Milestone: Priority: normal
Component: Theme Directory Keywords: needs-patch good-first-bug
Cc:

Description

Please visit any theme's page.
E.g. https://wordpress.org/themes/twentynineteen/

  1. The RSS button and Development Log text are not aligned properly.
  2. Because there as space before the Development Log text, underline also shows for that empty area.

Attachments (2)

alignment-issue.png (527.4 KB) - added by krupajnanda 10 months ago.
Screen Shot 2019-10-01 at 4.47.25 pm.png (17.5 KB) - added by dd32 9 months ago.

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


10 months ago

#2 @SergeyBiryukov
10 months ago

  • Keywords good-first-bug added

#3 @dd32
9 months ago

How about we switch this to using the Dashicon while we're at it for something a little more pleasing to the eye?
The existing image is pretty pixelated.

Thoughts on the above image?

#4 follow-up: @krupajnanda
8 months ago

Hi @dd32 ,

Thank you for sharing the screenshot but still, there is a little visible difference I can see.

#5 in reply to: ↑ 4 @dd32
8 months ago

Replying to krupajnanda:

Hi @dd32 ,

Thank you for sharing the screenshot but still, there is a little visible difference I can see.

Can you supply an example of what you'd expect?

This ticket was mentioned in Slack in #themereview by williampatton. View the logs.


7 months ago

#7 @williampatton
7 months ago

We chatted about this one a bit and think that a dashicon is likely the best, and easiest, option here. Alignment in the 2nd screenshot seems ok to me (it may be off by like 1px or something too low down but it's very minor, I can live with that).

#8 @krupajnanda
4 months ago

@dd32

Extremely sorry for the delay in response!

Yes, agree with @williampatton

We can go with screenshot 2.

Thanks,
Krupa

#9 @dd32
3 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9727:

Theme Directory: Swap out the RSS image icon for a dashicon variant.

Fixes #4721

#10 @dd32
3 months ago

In 9728:

Base theme: Correct typo in the unmarked lists CSS.

See #4721.

Note: See TracTickets for help on using tickets.