WordPress.org

Making WordPress.org

Opened 5 weeks ago

Last modified 3 weeks ago

#4730 new defect

unbalanced HTML in Plugins Home page

Reported by: joyously Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

If you run https://wordpress.org/plugins/ through a validator, you get quite a mess.
The main things are:

  • stray </span> tag for each plugin shown
  • duplicate ID post-xxxxx and plugin-slug for each (?)
  • <style> not allowed as child of element <a> for each plugin
  • unclosed <div> (for div with id="page")

Both https://validator.w3.org/nu/ and https://html5.validator.nu/ gave those errors, in addition to lots of other warnings.

Change History (3)

#1 @joyously
4 weeks ago

  • stray </span> tag for each plugin is in the theme

https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin.php#L60

  • duplicate ID post-xxxxx and plugin-slug

I think this is because some plugins can show in multiple sections since they are order_by rand.

  • <style> not allowed as child of element <a>

The style is output here:
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/client/components/plugin-icon/index.jsx#L37
Perhaps it should be srcset instead?

  • unclosed <div> (for div with id="page") is in the theme

It should be here:
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/footer.php#L17

#2 @dd32
3 weeks ago

AFAIK we can't use srcset as most of these need to be explicitly background images, which is why it's CSS in the first place.

We can probably drop the ID's though and switch to classes, so it won't matter if a plugin appears multiple times or has multiple <style>'s output.

This ticket was mentioned in Slack in #meta by joyously. View the logs.


3 weeks ago

Note: See TracTickets for help on using tickets.