WordPress.org
Get WordPress

Making WordPress.org

Changes between Initial Version and Version 1 of Ticket #4730, comment 23


Ignore:
Timestamp:
03/26/2023 05:08:28 AM (2 years ago)
Author:
sabernhardt
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #4730, comment 23

    initial v1  
    1 The image tags require an `alt` attribute. Leaving it empty as `alt=''` in the [https://github.com/WordPress/wordpress.org/blob/50ef8b1efc426f4905bae587959474175b5c42bb/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php#L400-L402 get_plugin_icon function] is an option, though. Then when an image is linked, either the link would need to include nearby visible text or else meaningful alternative text would replace the empty `alt=''`.
     1The image tags require an `alt` attribute. Leaving it empty as `alt=''` in the [https://github.com/WordPress/wordpress.org/blob/50ef8b1efc426f4905bae587959474175b5c42bb/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php#L400-L402 get_plugin_icon() function] is an option, though. Then when an image is linked, either the link would need to include nearby visible text or else meaningful alternative text would replace the empty `alt=''`.
    22
    3 In addition to the Plugin Directory page, this also affects embeds for plugins and themes. @alh0319 [https://wordpress.slack.com/archives/C02RP4X03/p1679777032833569 mentioned the embeds in Slack], in relation to the content on https://gdwp20.com/. Should those be handled on a separate ticket (or two, dividing plugin and theme embeds)?
     3In addition to the Plugin Directory page, this also affects embeds for plugins and themes. @alh0319 [https://wordpress.slack.com/archives/C02RP4X03/p1679777032833569 mentioned the embeds in Slack], in relation to the content on https://gdwp20.com/. Should those be handled on a separate ticket (or two, dividing plugin and theme embeds)? [https://github.com/sabernhardt/wordpress.org/pull/1 My draft PR] proposes several changes together (it may still need the `phpcs:ignore` and/or further editing).