Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 2 years ago

#4747 closed enhancement (fixed)

Feature Request: Expose/promote subchannels using /here by reposting to #core

Reported by: garrett-eclipse's profile garrett-eclipse Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Communication (Matrix, Slack, IRC) Keywords: has-patch
Cc:

Description

Hello,

Just an idea, not sure if possible or if there's much merit.

Was thinking as many Slack users aren't aware of all the channels it would be nice to give them a little exposure especially when they have meetings and bug scrubs by posting a snippet of their /here call to #core for example. Or #meta, etc for other channel types.

So a bug scrub starting in #core-privacy would put a little note/link on #core to let others know about it happening.

I feel especially for the smaller or newer components like Site Health, etc this could ellicit more participants.

Thank you

Attachments (6)

broadcast-in-core.png (66.9 KB) - added by dd32 5 years ago.
feature-notifications-chat.png (163.7 KB) - added by dd32 5 years ago.
Screen Shot 2019-12-04 at 9.14.25 AM.png (172.3 KB) - added by garrett-eclipse 5 years ago.
Some positive feedback
Screen Shot 2019-12-11 at 11.01.07 AM.png (82.6 KB) - added by garrett-eclipse 5 years ago.
Failure to perculate up to #core with 500 error. Still posted to the current channel though
4747.tide.diff (553 bytes) - added by garrett-eclipse 5 years ago.
The following patch introduces tide to the /here announcements to #core
4747.tide.switch.diff (931 bytes) - added by garrett-eclipse 5 years ago.
Alternate patch to change the if else block to a simpler switch case

Download all attachments as: .zip

Change History (31)

#1 @dd32
5 years ago

  • Keywords 2nd-opinion added
  • Type changed from defect to enhancement

This seems like a good idea to me, and I can see it working well for #meta.

I would assume that it would drop the @here part for the 'parent' channel and just have the text, or even just have it quote the message from the other channel using Slacks message embed functionality.

If there's any form of buy-in from the #core team then lets make this happen. I primarily want to make sure that adding this doesn't cause noise that is unwanted in the channels.

Marking this as 2nd-opinion only to gather extra feedback.

This ticket was mentioned in Slack in #core by dd32. View the logs.


5 years ago

#3 @dd32
5 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9216:

Slack: Broadcast /here messages in subchannels such as #core-privacy into thei parent channel (#core).

The message into the parent channel shouldn't contain any pinging content or be itself a here broadcast, and is trimmed to 100char if needed.

Fixes #4747.

#4 @dd32
5 years ago

The response in #core was good, so lets try this out.

[9216] implements this, but is 80% untested as I couldn't quite get slack to play nicely with me without actually putting it in production.

I'm hopeful that it'll work, and I'll try to be around in ~7hrs when it should be triggered.

If it doesn't quite work, reverting shouldn't be needed unless it broadcasts badly to the parent channel.

#5 @dd32
5 years ago

We may want to require a minimum message length (either characters, or words) before posting the parent channel to encourage everyone to use a reasonably descriptive and helpful notification.

#6 @dd32
5 years ago

In 9217:

Slack: When sending notifications to the 'parent' channel, keep in mind that some channels don't follow the #parent-subarea format.

See #4747.

#7 @dd32
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Here's an example of it happening overnight in #core: https://wordpress.slack.com/archives/C02RQBWTW/p1571666411454100 (Attached above)

That's an example of a /here that lacks context, the first line of the following message would've been better as the broadcast.

That's a good example of why multiple words being a requirement for an "upstream broadcast" makes sense IMHO.

Thoughts?

#8 @dd32
5 years ago

That's a good example of why multiple words being a requirement for an "upstream broadcast" makes sense IMHO.

Potentially even as part of the /here command - Require it be at least two words?

#9 @dd32
5 years ago

In 9221:

Slack: Allow the /here command to respect the users Slack avatar and display_name. Especially useful where real names are set in Slack and their WordPress.org username isn't obviously the same.

See #4747.

#10 @dd32
5 years ago

In 9222:

Slack: Correct the array indicies in [9221], these fields are nested under the profile key.

See r9221.
See #4747.

#11 @garrett-eclipse
5 years ago

Thanks @dd32 this is awesome, look forward to seeing it pop up more in #core. I agree having a minimum word count of 2+ seems to make sense to me and reduce spammy messaging.

#12 @dd32
5 years ago

  • Keywords 2nd-opinion removed
  • Resolution set to fixed
  • Status changed from reopened to closed

I'm going to close this as fixed.

After some thinking, I don't think we should implement controls on /here such as needing multiple words, I think that'd be better done through documentation of best practices. As others see the short broadcasts they should get the idea of adding a helpful description :)

@psykro is drafting up some documentation for the slash commands and how to use them, what they do, how to get whitelisted, etc. which should handle that well enough.

@garrett-eclipse
5 years ago

Some positive feedback

@garrett-eclipse
5 years ago

Failure to perculate up to #core with 500 error. Still posted to the current channel though

#13 @garrett-eclipse
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi @dd32 this seems to be a fairly successful feature. People seem to be enjoying it (screen) and I've personally found we're getting more people to participate in #core-privacy

One minor issue that cropped up today when I attempted the following command was a 500_service_error reported by Slackbox (screen), the command;
/here Come join Privacy Office Hours and we’ll continue our discussions on the Consent API and Disclosures tab

Reopening, but might just turn out to be a service disconnection. Or possibly I went beyond the string length limit?

#14 @dd32
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Unfortunately there aren't any logs for webhook deliveries from Slack, and no PHP fatals/warnings were generated on our side here from what I can see.
I suspect this may have been a temporary interruption or something on Slacks side.

If it happens more often, I'll look into it, but as it is, it's seemingly working..

#15 @garrett-eclipse
5 years ago

Thanks Dion, sounds like a plan. Will ping here if the issue crops up again.

This ticket was mentioned in Slack in #accessibility by sergey. View the logs.


5 years ago

#17 @SergeyBiryukov
5 years ago

In 9529:

Slack: Broadcast /here messages in #accessibility to #core.

Props afercia.
See #4747.

#18 @garrett-eclipse
5 years ago

@SergeyBiryukov should we do the same for #design?

#19 @SergeyBiryukov
5 years ago

In 9530:

Slack: Broadcast /here messages in #design to #core.

Props garrett-eclipse.
See #4747.

#20 @SergeyBiryukov
5 years ago

In 9548:

Slack: Fix typo in a function name called for trimming longer messages when broadcasting /here announcements to the parent channel.

Follow-up to [9216].

See #4747.

This ticket was mentioned in Slack in #meta by garrett-eclipse. View the logs.


5 years ago

#22 @JeffPaul
5 years ago

@SergeyBiryukov can we get this added for #tide as well? Please and thanks!

@garrett-eclipse
5 years ago

The following patch introduces tide to the /here announcements to #core

@garrett-eclipse
5 years ago

Alternate patch to change the if else block to a simpler switch case

#23 @garrett-eclipse
5 years ago

  • Keywords has-patch added

@SergeyBiryukov / @JeffPaul I provided a patch to add #tide to annoucements in #core.
4747.tide.diff is the basic patch
4747.tide.switch.diff is an alternate that changes the if-else block to a switch.

#24 @SergeyBiryukov
5 years ago

In 9583:

Slack: Broadcast /here messages in #tide to #core.

Props garrett-eclipse, JeffPaul.
See #4747.

#25 @dd32
2 years ago

In 11875:

Slack: Announce: Don' try to broadcast messages in private channels to the parent channel.

Some teams have private channels, which are in the format of #team-privatechannel, if there's any whitelisted users for the #team channel this would accidentally broadcast the private message publicly.
This has not been a problem in the past, as most private channels parent channels are also private (such as Security and Infrastructure related groups).

In an ideal world, we'd check to see if the channel status is the same (ie. if the parent channel was also private, we'd broadcast to that) but we don't have that information available in this handler.

See #4747.

Note: See TracTickets for help on using tickets.