WordPress.org

Making WordPress.org

Opened 4 months ago

Last modified 4 weeks ago

#4814 reopened defect

Pagination broken on themes

Reported by: jonoaldersonwp Owned by:
Milestone: Priority: high
Component: Theme Directory Keywords: seo
Cc:

Description

Attempting to navigate to paginated states of theme results (e.g., https://wordpress.org/themes/tags/right-sidebar/, and https://wordpress.org/themes/browse/popular/page/3/) results in a 302 redirect to the series root.

This should instead return the correct paginated state.

Change History (14)

#1 @Otto42
4 months ago

I'm somewhat confused, as the themes directory has no pagination. It's an infinite scroller.

#2 @jonoaldersonwp
4 months ago

Disable JavaScript / look at the source code.

#3 @dd32
4 months ago

  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #4092.

#4 @jonoaldersonwp
4 months ago

  • Resolution duplicate deleted
  • Status changed from closed to reopened

This did work previously, and has since broken. It's currently a critical issue, and we can't wait on an ethereal timeline for a backbone/JS solution.

#5 follow-up: @dd32
4 months ago

  • Resolution set to duplicate
  • Status changed from reopened to closed

See [8126] on #4092 - Intentional

#6 @jonoaldersonwp
4 months ago

  • Resolution duplicate deleted
  • Status changed from closed to reopened

I'm not sure what I'm looking at in that changelog, but intentional or otherwise, this needs fixing.

It was previously the case that it was possible to request and return paginated states of these archives. That's now not the case. That functionality needs to be restored.

#7 in reply to: ↑ 5 @dd32
4 months ago

Replying to dd32:

See [8126] on #4092 - Intentional

Sorry, that was [9064] via #4613

This seems fine as-is.

#8 @dd32
4 months ago

  • Resolution set to wontfix
  • Status changed from reopened to closed

Closing as wontfix instead then.

We don't support pagination on the current-generation theme directory, and no links should exist to it.

We may add pagination in the future, when/if the theme directory gets re-engineered.

#9 follow-up: @jonoaldersonwp
4 months ago

Ah, so these should 404, not 302.

#10 in reply to: ↑ 9 @dd32
4 months ago

Replying to jonoaldersonwp:

Ah, so these should 404, not 302.

In an ideal universe, but if links exist in the wild as you suggest, directing to the index is the best user experience here.

#11 follow-up: @jonoaldersonwp
4 months ago

Gah. Yes, but this is really bad. Can we up the priority on the JS fix stuff? OR, support pagination here?

#12 in reply to: ↑ 11 @dd32
4 months ago

Replying to jonoaldersonwp:

Gah. Yes, but this is really bad. Can we up the priority on the JS fix stuff? OR, support pagination here?

Both are super-low priority, and realistically will never be supported unless the directory has a new UI and backend added.

#13 @jonoaldersonwp
6 weeks ago

  • Priority changed from highest omg bbq to high
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Revisiting this one, as it's an absolutely crippling SEO, UI and accessibility nightmare.

TL;DR, the themes directory uses JavaScript to provide an 'infinite scroll' mechanism, but conventional pagination (whilst exposed) is broken.

With JS disabled, the themes template(s) contains/reveals a pagination component (which links to a series of /page/n/ derivatives of the current query).

However, requesting paginated URLs triggers a 302 redirect to the series root.

In short, we _have_ to support pagination on themes, regardless of the complexity or resource cost. This is non-negotiable, as theme discovery, crawling and indexing is currently severely impacted.

Requests to https://wordpress.org/themes/page/4/ (and similarly, filtered flavours, like https://wordpress.org/themes/browse/new/page/4/) must return the (server-side) appropriately paged results for the query in question.

This may require some additional adjustment of the JS 'on top' of the server-side response.

This ticket was mentioned in Slack in #meta by jonoaldersonwp. View the logs.


4 weeks ago

Note: See TracTickets for help on using tickets.