WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#4839 closed enhancement (fixed)

Update themes upload page

Reported by: dingo_d Owned by: dd32
Milestone: Priority: high
Component: Theme Directory Keywords: has-patch dev-feedback
Cc:

Description

Current page https://wordpress.org/themes/upload/ is a mix of content from the admin and page template.

This makes the site non-translatable, which can be a problem as presented here https://sv.wordpress.org/themes/upload/

The patch I've created will add all the content in the page template.

Another bug this fixes is the fact that the wporg-themes-upload shortcode echoed the content out instead of returning it, which caused errors on page update from the admin (plus the shortcode was literally present in the admin area).

I'll submit a patch that covers page-upload.php in the wporg-themes theme and upload.php in the theme-directory plugin.

When this will be applied, the content on the page should be removed (aside from the shortcode which should remain).

Attachments (1)

4839.diff (5.0 KB) - added by dingo_d 2 years ago.

Download all attachments as: .zip

Change History (7)

@dingo_d
2 years ago

#1 @dd32
2 years ago

  • Owner set to dd32
  • Status changed from new to accepted

#2 @dd32
22 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 9345:

Theme Directory: Convert the uploads page into a real shortcode (That returns content) and hard-code the strings on the upload page to allow translation.

Props dingo_d.
Fixes #4839.

#3 follow-up: @tobifjellner
22 months ago

There was a typo in a translators comment: Theme Handbook Requied Review items.

#4 @tobifjellner
22 months ago

One more thing: It's a bit strange to hardcode the pseudo filename themename.zip in the text. It would be better to allow it to be translated.

#5 @dd32
22 months ago

In 9351:

Themes: Correct a typo in a translator comment.

Props tobifjellner.
See #4839.

#6 in reply to: ↑ 3 @dd32
22 months ago

Replying to tobifjellner:

There was a typo in a translators comment: Theme Handbook Requied Review items.

..I really need to get my Mac keyboard replaced.. (The R key doesn't work too well sometimes).

Fixed. Thanks!

One more thing: It's a bit strange to hardcode the pseudo filename themename.zip in the text. It would be better to allow it to be translated.

While I agree, I don't trust it to be translated properly/well and I don't think there's a massive benefit to translating it, as most locales will likely translate it as-is.

Note: See TracTickets for help on using tickets.