Opened 5 years ago
Closed 5 years ago
#4929 closed defect (bug) (fixed)
Prevent users from uploading themes without readme.txt files
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Component: | Theme Directory | Keywords: | |
| Cc: |
Description
Themes are required to include a readme.txt file.
Themes that does not include a readme.txt should be prevented from being uploaded.
This would need to be added to
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php#L115
Change History (2)
#2
@
5 years ago
- Resolution set to fixed
- Status changed from new to closed
Correct, the pull in https://github.com/WordPress/theme-check/pull/206 will also address this without modifying the uploader code.
Change committed in https://plugins.trac.wordpress.org/changeset/2218381. It will be included in a future release of the plugin, but the trunk change makes it work on w.org now.
Note: See
TracTickets for help on using
tickets.
I submitted a PR for Theme Check to make the readme.txt required. If it is merged, then that would produce an Error, so the upload would not proceed. But I don't see where the Theme Check is invoked in that code you referenced.