WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#493 closed enhancement (fixed)

Code reference: Add search form to internal pages

Reported by: SergeyBiryukov Owned by: nicole@…
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

#172 is marked as fixed, but the search form is only displayed on the main page.

It should be added to internal pages too, like http://developer.wordpress.org/reference/functions/get_terms/.

Attachments (6)

493.patch (62.3 KB) - added by zamfeer 5 years ago.
a simple solution that places a smaller search form in the header on internal pages
search-bar-hidden.png (65.9 KB) - added by coffee2code 5 years ago.
Quick mockup of the hidden-by-default slide down search bar
search-bar-visible.png (69.0 KB) - added by coffee2code 5 years ago.
Quick mockup of the hidden-by-default slide down search bar (when visible)
search.diff (3.9 KB) - added by nlarnold1 5 years ago.
Adds toggle search
search.2.diff (6.5 KB) - added by nlarnold1 5 years ago.
This one includes the responsive adjustments
search.js (221 bytes) - added by nlarnold1 5 years ago.
new js file for patch

Download all attachments as: .zip

Change History (20)

#1 @SergeyBiryukov
5 years ago

  • Type changed from defect to enhancement

#2 @coffee2code
5 years ago

#539 was marked as a duplicate.

#3 @coffee2code
5 years ago

We could stand to have someone submit mockups for this.

Given the single column design of the site, I imagine this will end up being a slide-down search bar, hidden by default (like the screen options panel in core). Having the search form static at the top of the page (as done on the main page) is too prominent on single and archive pages. Having it at the bottom is too out of the way.

Unless, of course, we add a sidebar. In which case, the search form can be a widget in it.

@zamfeer
5 years ago

a simple solution that places a smaller search form in the header on internal pages

#4 @zamfeer
5 years ago

  • Cc andrew@… added
  • Keywords has-patch added

#5 @SergeyBiryukov
5 years ago

493.patch has a lot of unrelated changes to stylesheets/main.css.

Last edited 5 years ago by SergeyBiryukov (previous) (diff)

#6 @coffee2code
5 years ago

In 742:

Code Reference: add search form to search results page.

  • Add search form to top of search results page
  • Add breadcrumb for search results page
  • Make searchform template applicable outside of reference landing page

See #450, #494 #493.

(manually posting this as the commit comment referenced the wrong ticket)

#7 @siobhan
5 years ago

  • Owner set to nicole@…
  • Status changed from new to assigned

@coffee2code
5 years ago

Quick mockup of the hidden-by-default slide down search bar

@coffee2code
5 years ago

Quick mockup of the hidden-by-default slide down search bar (when visible)

#8 @coffee2code
5 years ago

For the reasons mentioned above, I've gone ahead and done a quick mockup of the slide down search bar I proposed. This would be present throughout the code reference.

By default, it would be hidden. Clicking the search icon would cause the search bar to slide down and become visible.

For the search results page, this form could default to being visible by default (perhaps not being allowed to slide up either). The existing search form on the top of the search results page would be removed in favor of using this.

#9 @coffee2code
5 years ago

#657 was marked as a duplicate.

@nlarnold1
5 years ago

Adds toggle search

@nlarnold1
5 years ago

This one includes the responsive adjustments

This ticket was mentioned in Slack in #meta-devhub by coffee2code. View the logs.


5 years ago

@nlarnold1
5 years ago

new js file for patch

This ticket was mentioned in Slack in #meta-devhub by coffee2code. View the logs.


5 years ago

#12 @coffee2code
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 990:

developer.wordpress.org: add search form to internal pages

fixes #493.
props nlarnold1.

#13 @coffee2code
5 years ago

Three minor changes from search.2.diff:

  • Added a container div around #inner-search-icon (and associated CSS changes) so the icon could be floated right rather than absolutely positioned. This was to allow the search icon to cause text (namely the breadcrumbs) to flow around it at smaller widths rather than covering up the text.
  • Made it so search appears for parsed taxonomies too ('wp-parser-since', 'wp-parser-package', 'wp-parser-source-file')
  • Wrapped logic for determining if the search bar should be shown into should_show_search_bar()

#14 @jdgrimes
5 years ago

I don't know if this has been addressed already, but it seems odd to me that that the cursor for the search tab is the I-beam. Because it is clickable I'd expect it to be the pointer.

Note: See TracTickets for help on using tickets.