#493 closed enhancement (fixed)
Code reference: Add search form to internal pages
Reported by: | SergeyBiryukov | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Developer Hub | Keywords: | has-patch |
Cc: |
Description
#172 is marked as fixed, but the search form is only displayed on the main page.
It should be added to internal pages too, like http://developer.wordpress.org/reference/functions/get_terms/.
Attachments (6)
Change History (20)
#3
@
10 years ago
We could stand to have someone submit mockups for this.
Given the single column design of the site, I imagine this will end up being a slide-down search bar, hidden by default (like the screen options panel in core). Having the search form static at the top of the page (as done on the main page) is too prominent on single and archive pages. Having it at the bottom is too out of the way.
Unless, of course, we add a sidebar. In which case, the search form can be a widget in it.
#6
@
10 years ago
In 742:
Code Reference: add search form to search results page.
- Add search form to top of search results page
- Add breadcrumb for search results page
- Make searchform template applicable outside of reference landing page
(manually posting this as the commit comment referenced the wrong ticket)
#8
@
10 years ago
For the reasons mentioned above, I've gone ahead and done a quick mockup of the slide down search bar I proposed. This would be present throughout the code reference.
By default, it would be hidden. Clicking the search icon would cause the search bar to slide down and become visible.
For the search results page, this form could default to being visible by default (perhaps not being allowed to slide up either). The existing search form on the top of the search results page would be removed in favor of using this.
This ticket was mentioned in Slack in #meta-devhub by coffee2code. View the logs.
10 years ago
This ticket was mentioned in Slack in #meta-devhub by coffee2code. View the logs.
10 years ago
#13
@
10 years ago
Three minor changes from search.2.diff:
- Added a container div around #inner-search-icon (and associated CSS changes) so the icon could be floated right rather than absolutely positioned. This was to allow the search icon to cause text (namely the breadcrumbs) to flow around it at smaller widths rather than covering up the text.
- Made it so search appears for parsed taxonomies too ('wp-parser-since', 'wp-parser-package', 'wp-parser-source-file')
- Wrapped logic for determining if the search bar should be shown into
should_show_search_bar()
#539 was marked as a duplicate.