WordPress.org

Making WordPress.org

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#5019 closed task (fixed)

Switch to `manifest.json` in Block Editor docs importer

Reported by: chrisvanpatten Owned by: coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords: commit
Cc:

Description

In #4388 we set up a manifest-devhub.json file in the block editor repo as the source for the devhub manifest.

The patch (to be attached) reverts it to use manifest.json. I've also rebased the associated PR in the Gutenberg repo, so it's ready to go.

Attachments (1)

5019.diff (828 bytes) - added by chrisvanpatten 9 months ago.
Patch to revert to manifest.json

Download all attachments as: .zip

Change History (10)

@chrisvanpatten
9 months ago

Patch to revert to manifest.json

This ticket was mentioned in Slack in #meta-devhub by chrisvanpatten. View the logs.


9 months ago

This ticket was mentioned in Slack in #core-editor by chrisvanpatten. View the logs.


9 months ago

#3 @chrisvanpatten
9 months ago

Note: the Gutenberg PR should be merged first, because the current manifest.json file is fairly out of date. If this patch is merged first, it could cause some out-of-date pages to appear.

#4 @netweb
9 months ago

  • Keywords commit added

Looks good to me, I've approved the GB PR, so once this lands, the GB PR can be merged

Edit: I merged the GB PR so this is ready for commit

Last edited 9 months ago by netweb (previous) (diff)

#5 @chrisvanpatten
9 months ago

  • Component changed from Handbooks to Developer Hub

Oops, this was in the wrong component. My bad!

This ticket was mentioned in Slack in #docs by chrisvanpatten. View the logs.


9 months ago

#7 @coffee2code
9 months ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 9482:

Developer theme: Update Block Editor manifest URL.

Props chrisvanpatten, netweb.
Fixes #5019.

#8 @coffee2code
9 months ago

@chrisvanpatten: I believe there has been some talk in places that the manifest should point to a copy in a branch tied to the latest WP release. Should that be the next step, so that the handbook on DevHub doesn't reflect features and changes present in the master branch but not packaged with the latest WP?

#9 @coffee2code
9 months ago

Nevermind, just noticed #5020.

Note: See TracTickets for help on using tickets.