Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5031 closed defect (bug) (fixed)

Support Forums: Duplicate "Create Review" button

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Support Forums Keywords: has-screenshots
Cc:

Description (last modified by SergeyBiryukov)

Background: [9463] and [9464] added a new "Create Topic" / "Create Review" button.

There are a few problems with it:

  • If you haven't already left a review for the plugin, there's already an "Add your own review" button just above, which looks differently.
  • If you have already left a review, the button above says "Edit your review" (since you can only leave one review per plugin), while the button below still says "Create Review", which is misleading.
  • If the plugin doesn't have any reviews yet, the new button is not displayed, only the old one.

These buttons should be merged together, there's no point in having two conflicting buttons next to each other.

Attachments (4)

5031.png (32.0 KB) - added by SergeyBiryukov 5 years ago.
sidebyside.png (124.6 KB) - added by dufresnesteven 5 years ago.
I would lean towards keeping the button on the aggregate section since they most likely have come from the specific plugin review page. I would be less familiar with the forum and its experience.
5031.diff (1.6 KB) - added by dufresnesteven 5 years ago.
Removes the button above the table if we are looking at reviews.
5031.2.diff (911 bytes) - added by dufresnesteven 5 years ago.
Removes the button above the table if we are looking at reviews.

Download all attachments as: .zip

Change History (8)

@SergeyBiryukov
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Description modified (diff)

#2 @dufresnesteven
5 years ago

Is the solution to just hide the Create Review button when users are viewing plugin/theme reviews?

@dufresnesteven
5 years ago

I would lean towards keeping the button on the aggregate section since they most likely have come from the specific plugin review page. I would be less familiar with the forum and its experience.

@dufresnesteven
5 years ago

Removes the button above the table if we are looking at reviews.

@dufresnesteven
5 years ago

Removes the button above the table if we are looking at reviews.

#3 @coffee2code
5 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 9894:

Support Forums: Omit 'Create Topic' button above listings of reviews.

The rating section, which is in close proximity, already has such a button but with more context awareness.

Props dufresnesteven.
Fixes #5031.

#4 @coffee2code
5 years ago

In 9895:

Support theme: After r9894, make search field full-width.

This was the case prior to the introduction of the now-removed button.

See #5031.

Note: See TracTickets for help on using tickets.