Making WordPress.org

Opened 5 years ago

Closed 5 years ago

#5037 closed defect (bug) (fixed)

Remove all inline microdata from themes templates

Reported by: jonoaldersonwp's profile jonoaldersonwp Owned by: dd32's profile dd32
Milestone: Priority: high
Component: Theme Directory Keywords: seo
Cc:

Description

Themes templates, like https://wordpress.org/themes/shuttle-gominimal/, contain inline microdata (such as aggregateRating properties on .theme-ratings).

However, almost all of this markup is incorrect and/or outdated.

It should be removed, as a precursor to a follow-up ticket which will adapt and implement the (correct) JSON-ID approach used on plugin templates.

Specifically, the following should be removed from the whole template:

  • Any <meta> tags used inline to house itemprop or similar properties (e.g., <meta itemprop="ratingCount" content="0"/>).
  • Any itemprop properties.
  • Any itemtype properties.
  • Any itemscope properties.

Change History (5)

#1 @dingo_d
5 years ago

Just for the clarification, you are referring to .org themes page theme or all the themes in the directory?

http://meta.svn.wordpress.org/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-themes/theme-single.php

This is the official theme that has itemprops there. Asking every theme to remove the itemprops from their themes would mean we would have to make this as a requirement for the review process, and then check themes for yet another thing... It would just be too much to ask from reviewers imo (they are already complaining about too many requirements).

#2 @jonoaldersonwp
5 years ago

The pages in the directory, as per my example / the source file you referenced.

#3 @dd32
5 years ago

It should be removed, as a precursor to a follow-up ticket which will adapt and implement the (correct) JSON-ID approach used on plugin templates.

Let's implement that and remove these at the same time.

#4 @jonoaldersonwp
5 years ago

@dd32 Okay!

I'm looking at the schema block on https://en-gb.wordpress.org/plugins/wordpress-seo/, and I think we can just copy + adapt that safely.

Aside from adapting all of the field values (names, images, descriptions, etc). I think the only difference in the structures is that the value of applicationCategory should be "Theme".

#5 @dd32
5 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9533:

Theme Directory: Swap out inline metadata for a JSON+LD object.

Fixes #5037.

Note: See TracTickets for help on using tickets.