Opened 10 years ago

Closed 8 years ago

#505 closed defect (bug) (fixed)

Plugins Zip Builder Tags v. Branches namespacing conflict

Reported by: georgestephanis's profile georgestephanis Owned by: otto42's profile Otto42
Milestone: Priority: normal
Component: Plugin Directory Keywords: dev-feedback


If a software project like bbPress runs tags and branches named the same -- for example, having a structure that looks something like


and keeps the 2.5 branch up to date, so that it is reflecting the current 2.5.4 release, the download of the 2.5 release will actually be the 2.5.4 release.

Test it for yourself:

This is because of a naming conflict when branches and tags have their zip packages made.

Tags are generated as:{$tag_directory}.zip

Branches are generated as:{$branch_directory}.zip

If they have the same name, then I believe the zips are regenerated as the files in that directory is modified? Regardless, the zip of the 2.5 tagged release gets overwritten with the 2.5 branch.

This is particularly problematic if current stable is 2.5, and a 2.5.1 point release is being prepared in the 2.5 branch. Code that may not be yet meant for release into the world is getting delivered to every user that installs or upgrades to current stable.

This is bad.

Ideal and I suspect easiest resolution would be to change the branch zip filenames to{$branch_directory}.zip

Change History (12)

#1 @nacin
10 years ago

I am/was not aware that branches generated zips.

#2 @mdawaffe
10 years ago

I didn't even know we made ZIPs for branches :)

Should we just not?

#3 @Otto42
10 years ago

Yes, branches do get turned into ZIP files. I discovered this the hard way when Jetpack had an issue with this.

We could just turn off the ZIPs for branches. I'd be okay with that.

#4 @georgestephanis
10 years ago

Especially as feature branches are normally in active development, with a lot of commits going in, it seems silly to rebuild the zip after each commit.

+1 to just not building zips for branches.

This ticket was mentioned in IRC in #wordpress-meta by sams. View the logs.

10 years ago

#6 @samuelsidler
10 years ago

  • Owner set to Otto42
  • Status changed from new to assigned

#7 @netweb
10 years ago

  • Cc stephen@… added

#8 @SergeyBiryukov
9 years ago

  • Keywords needs-patch removed

Removing 'needs-patch' from components that are not open sourced yet, to help focus on tickets that actually need a patch.

This ticket was mentioned in Slack in #meta by ocean90. View the logs.

8 years ago

#10 @ocean90
8 years ago

@Otto42 Any news here?

#11 @dd32
8 years ago

In 3081:

Plugin Directory: Add an initial set of scripts to build & serve ZIP files.

See #505 - The new directory doesn't build ZIPs for branches.
See #1578

#12 @dd32
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Given this has existed for 2 years, i'm going to mark this as fixed in the new directory.

Note: See TracTickets for help on using tickets.