WordPress.org
Get WordPress

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#5057 closed defect (bug) (fixed)

Remove comments from pull request description

Reported by: isabel_brison's profile isabel_brison Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

Following on from ​https://core.trac.wordpress.org/ticket/49508, PR descriptions that get synced to core Trac currently include all the boilerplate comments, which makes the descriptions hard to read.

It would be good to filter out those comments from the payload that comes from the GitHub API.

Change History (3)

#1 @dd32
5 years ago

Looks like there's two things that needs doing here for the best experience:

  • Strip HTML comments
  • Strip ---\r\n\*\*.+\*\*$ from the response to remove the code-review last-line in a way that will preserve anything else added to the desc.

#2 @dd32
5 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9539:

Trac: Github PRs: Filter out HTML comments and standard code-review-only boilerplate from PR descriptions before posting them to Trac.

Props isabel_brison for the suggestion.
Fixes #5057.

#3 @dd32
4 years ago

In 9877:

Trac: Github PRs: Actually filter out HTML comments.

This commit message is longer than the fix.

Amends [9539].
See #5057.
Fixes #5213.

Note: See TracTickets for help on using tickets.