Opened 3 years ago
Last modified 16 months ago
#5065 new defect (bug)
Get involved sub-menu should include a link to Make
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Make (Get Involved) / P2 | Keywords: | has-patch |
Cc: |
Description
Usability-wise, the "Get Involved" menu lets you either click on the parent menu item to go to make.wordpress.org or its single sub-menu item "Five for the Future".
I consider we should change this to allow people to reach Make easier. Right now, they'd have to click on the parent menu item itself, which conflicts with the sub-menu showing up usability-wise.
My suggestion would be to include a sub-menu linking to Make.
Attachments (1)
Change History (8)
#2
@
16 months ago
@dufresnesteven @garrett-eclipse I want to contribute to this ticket. I need access to this site. And I wanted that either this could be achieved by adding sub menu pages to get involved parent menu, or it involves custom stuff for which I have to make a PR.
Thanks!
#3
@
16 months ago
Hey @muhammadfaizanhaidar,
You can find the code for the new WordPress.org header here: https://github.com/WordPress/wporg-mu-plugins/tree/trunk/mu-plugins/blocks/global-header-footer
The simplest way to test it locally, is to run the new News theme that includes it: https://github.com/WordPress/wporg-news-2021
#4
follow-up:
↓ 5
@
16 months ago
@dd32 thanks for your help after reviewing the mu plugins code and reading the above ticket I found out that there is no need to add new sub menu items via hard coding I think this can be done by WP admin from appearance menu settings where one can drag and drop sub menu pages here.
Please correct me if I am wrong.
Thanks!
#5
in reply to:
↑ 4
@
16 months ago
Replying to muhammadfaizanhaidar:
@dd32 thanks for your help after reviewing the mu plugins code and reading the above ticket I found out that there is no need to add new sub menu items via hard coding I think this can be done by WP admin from appearance menu settings where one can drag and drop sub menu pages here.
For WordPress.org, it's hard-coded here:
https://github.com/WordPress/wporg-mu-plugins/blob/trunk/mu-plugins/blocks/global-header-footer/blocks.php#L435-L539
For Rosetta (international sites), it's hard-coded, in.. a file that I don't think is open-source right now.
#6
@
16 months ago
I have added a patch to this ticket.
PR: https://github.com/WordPress/wporg-mu-plugins/pull/130
Patch Links:
It might also be useful to provide the Meetings and Team Updates link in that dropdown. They're available from the Make site itself as top level pages so would make sense to provide them within the Get Involved sub-menu.