Making WordPress.org

Opened 4 years ago

Closed 4 months ago

Last modified 4 months ago

#5065 closed defect (bug) (fixed)

Get involved sub-menu should include a link to Make

Reported by: valentinbora's profile valentinbora Owned by:
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: has-patch
Cc:

Description

Usability-wise, the "Get Involved" menu lets you either click on the parent menu item to go to make.wordpress.org or its single sub-menu item "Five for the Future".

I consider we should change this to allow people to reach Make easier. Right now, they'd have to click on the parent menu item itself, which conflicts with the sub-menu showing up usability-wise.

My suggestion would be to include a sub-menu linking to Make.

Attachments (1)

Screen Shot 2020-03-25 at 1.20.32 PM.png (41.6 KB) - added by dufresnesteven 4 years ago.
I agree. It would makes sense to have meetings & team updates.

Download all attachments as: .zip

Change History (10)

#1 @garrett-eclipse
4 years ago

It might also be useful to provide the Meetings and Team Updates link in that dropdown. They're available from the Make site itself as top level pages so would make sense to provide them within the Get Involved sub-menu.

@dufresnesteven
4 years ago

I agree. It would makes sense to have meetings & team updates.

#2 @muhammadfaizanhaidar
2 years ago

@dufresnesteven I want to contribute to this ticket. I need access to this site. And I wanted that either this could be achieved by adding sub menu pages to get involved parent menu, or it involves custom stuff for which I have to make a PR.
Thanks!

Version 0, edited 2 years ago by muhammadfaizanhaidar (next)

#3 @dd32
2 years ago

Hey @muhammadfaizanhaidar,

You can find the code for the new WordPress.org header here: https://github.com/WordPress/wporg-mu-plugins/tree/trunk/mu-plugins/blocks/global-header-footer

The simplest way to test it locally, is to run the new News theme that includes it: https://github.com/WordPress/wporg-news-2021

#4 follow-up: @muhammadfaizanhaidar
2 years ago

@dd32 thanks for your help after reviewing the mu plugins code and reading the above ticket I found out that there is no need to add new sub menu items via hard coding I think this can be done by WP admin from appearance menu settings where one can drag and drop sub menu pages here.
Please correct me if I am wrong.
Thanks!

#5 in reply to: ↑ 4 @dd32
2 years ago

Replying to muhammadfaizanhaidar:

@dd32 thanks for your help after reviewing the mu plugins code and reading the above ticket I found out that there is no need to add new sub menu items via hard coding I think this can be done by WP admin from appearance menu settings where one can drag and drop sub menu pages here.

For WordPress.org, it's hard-coded here:
https://github.com/WordPress/wporg-mu-plugins/blob/trunk/mu-plugins/blocks/global-header-footer/blocks.php#L435-L539

For Rosetta (international sites), it's hard-coded, in.. a file that I don't think is open-source right now.

#7 @muhammadfaizanhaidar
2 years ago

  • Keywords has-patch added

#8 @coffee2code
4 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing as 'fixed' for lack of a better resolution. The global nav menu has been revamped since this ticket was filed. The "Get Involved" menu has been replaced with "Community", under which "Make WordPress" is listed as one of the options. And clicking the parent menu option now just toggles the display of the submenu rather than linking off somewhere.

As for the suggestions to add "Meetings" and "Team Updates" to that submenu, doing so makes less sense now that the global nav was revamped. The "Community" submenu already has six links, which is the most a submenu there has (unlike only 1 submenu link previously). And the "Meetings" and "Team Updates" links seem too niche for the global nav. They are featured in an in-page nav on https://make.wordpress.org/ which is more appropriate (and might've been introduced after this ticket).

This ticket was mentioned in PR #130 on WordPress/wporg-mu-plugins by @muhammadfaizanhaidar.


4 months ago
#9

Added Meetings and Team Updates submenus to Get Involved parent menu.
Track ticket: https://meta.trac.wordpress.org/ticket/5065

Note: See TracTickets for help on using tickets.