WordPress.org

Making WordPress.org

Opened 5 years ago

Closed 5 years ago

#513 closed defect (fixed)

Submit button in Rosetta contact forms has incorrect padding

Reported by: SergeyBiryukov Owned by: iandunn
Milestone: Priority: normal
Component: International Sites (Rosetta) Keywords:
Cc:

Description

See the screenshot.

Attachments (3)

meta-513.png (2.5 KB) - added by SergeyBiryukov 5 years ago.
513.diff (388 bytes) - added by iamfriendly 5 years ago.
Fix line-height in buttons by making them unitless
513-2.diff (674 bytes) - added by iamfriendly 5 years ago.
Adjusted font-size, padding, height and width to be more inline with other buttons and other inputs in the form

Download all attachments as: .zip

Change History (8)

#1 @SergeyBiryukov
5 years ago

Removing or overriding inherited line-height: 23px appears to fix this.

#2 @SergeyBiryukov
5 years ago

The font size should probably be increased as well, since it's a lot smaller than the rest of text on the page.

@iamfriendly
5 years ago

Fix line-height in buttons by making them unitless

#3 @iamfriendly
5 years ago

Fix line-height in buttons by making them unitless.

As per http://meyerweb.com/eric/thoughts/2006/02/08/unitless-line-heights/ and http://css-tricks.com/almanac/properties/l/line-height/ line-heights are generally best left to be unitless. This especially applies to elements such as buttons where there's nothing to inherit.

The attached patch overrides the buttons css that is set in wp4.css (including the same selectors that that file sets)

In terms of font-size (and padding) I'm going to submit a separate patch as that needs to handle over-riding a different selector as that uses an ID.

@iamfriendly
5 years ago

Adjusted font-size, padding, height and width to be more inline with other buttons and other inputs in the form

#4 @iamfriendly
5 years ago

In 51302.diff Adjusted font-size, padding, height and width to be more inline with other buttons and other inputs in the form

Last edited 5 years ago by iamfriendly (previous) (diff)

#5 @iandunn
5 years ago

  • Owner set to iandunn
  • Resolution set to fixed
  • Status changed from new to closed

In 764:

Rosetta theme: Correct padding on contact form submit button.

Fixes #513
props iamfriendly

Note: See TracTickets for help on using tickets.