Making WordPress.org

Opened 4 years ago

Closed 2 years ago

#5142 closed defect (bug) (invalid)

Need the three dots position fix at the end.

Reported by: vinita29's profile vinita29 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Priority: normal
Component: WordPress.org Site Keywords: has-screenshots close 2nd-opinion
Cc:

Description

In https://wordpress.org/ Below the footer -WordPress Users section bottom three dots position fix at the end. like (and hundreds more...) this will be more good.

Attachments (3)

three_dots_position_fix.png (79.1 KB) - added by vinita29 4 years ago.
5142.diff (2.0 KB) - added by whyisjake 4 years ago.
#5142.patch (1.2 KB) - added by rehanali 2 years ago.
Added patch

Download all attachments as: .zip

Change History (14)

#1 follow-up: @Otto42
4 years ago

I'm confused, what is the issue here?

#2 follow-up: @whyisjake
4 years ago

Hi @vinita29, I think you are trying to point out that the dots should be at the end of the string, not the beginning?

#3 in reply to: ↑ 2 @vinita29
4 years ago

Replying to whyisjake:

Hi @whyisjake ,

Yes exactly.

#4 in reply to: ↑ 1 @vinita29
4 years ago

Replying to Otto42:

Hello Otto42,

In http://wordpress.org/ Below the footer -WordPress Users section bottom three dots position to place at the end.
like (and hundreds more...).
Thankyou.

@whyisjake
4 years ago

#5 follow-up: @whyisjake
4 years ago

Added a little diff to swap the position. PHBCBF fixes came along with it.

#6 in reply to: ↑ 5 @vinita29
4 years ago

Replying to whyisjake:

Ok

#7 @dd32
4 years ago

  • Keywords close 2nd-opinion added

Those phpcbf changes can be ignored, and I'm fairly sure this string is intentional and correct.

The ellipses take the place of the missed words, and in this sentence, they're the company logos displayed above. There isn't any words intentionally missed from the end of the sentence.

Rule 1 here is an example of this, it's most commonly used in non-formal writing, but seems correct in this case.

#8 @whyisjake
4 years ago

I can see the use case for either rule 1, as you have noted, but I think that there really isn't a sentence formed the headline, and then images, followed by a paragraph at the end of the block. It seems like Rule 2 here: would be a better fit.

Last edited 4 years ago by whyisjake (previous) (diff)

#9 @whyisjake
4 years ago

(I don't care too much tho, it could really go either way... Prolly need a period or a bang at the end of the sentence.)

@rehanali
2 years ago

Added patch

#10 @dd32
2 years ago

@rehanali #5142.patch isn't any different to 5142.diff - did you upload the wrong file?

#11 @dd32
2 years ago

  • Resolution set to invalid
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.