Opened 10 years ago

Closed 8 years ago

#515 closed defect (bug) (fixed)

Separate search results for handbooks and P2/blog

Reported by: siobhan's profile siobhan Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Handbooks Keywords:


When I do a search on make/core, it displays pages from the handbook in the search results. So, for example, I [do a search for release leads]( and the results display a page that I wrote in the handbook.

This feels out of place in these search results. The handbooks and the associated discussion blog should have separate searches.

Change History (7)

This ticket was mentioned in Slack in #meta by sam. View the logs.

8 years ago

#2 @samuelsidler
8 years ago

  • Summary changed from P2 Make blog search results displays handbook pages to Separate search results for handbooks and P2/blog


We should have two search boxes. I think we added handbook results because we only had one search box. Instead, let's have a search for the handbooks and a separate one for the the rest of the P2.

#3 @coffee2code
8 years ago

In 3234:

Handbook plugin: Add four template tags relating to handbook pages.

Specifically: wporg_get_handbook_post_types(), wporg_is_handbook(), wporg_is_handbook_post_type(), and wporg_get_current_handbook().

Props keesiemeijer.
See #515, #1671.
Fixes #1693.

#4 @coffee2code
8 years ago

In 3235:

Handbook plugin: Add template tag wporg_get_current_handbook_home_url() to get home URL for current handbook.

See #515, #1671.

#5 @coffee2code
8 years ago

In 3236:

Handbook plugin: Don't modify handbook archive query when handling search.

Allows for handbook-only searches.

See #515, #1671.

#6 @coffee2code
8 years ago

In 3237: P2 child theme: Add search.php template to handle loading handbook-specific template part (added as well) in search results.

See #515.

#7 @coffee2code
8 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 3238: P2 child theme: Add searchform.php template for context aware handbook/non-handbook search form submission URLs.

Fixes #515.

Note: See TracTickets for help on using tickets.