WordPress.org

Making WordPress.org

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#5166 closed enhancement (fixed)

Prevent moderators from approving 'combined' speakers

Reported by: casiepa Owned by: dd32
Milestone: Priority: normal
Component: WordPress.tv Keywords: 2nd-opinion
Cc:

Description

When editing a video for publication, the speakers are proposed as they were entered in the submit form. Moderators can hit the 'Approve' button and speakers are then added directly into the 'speakers' taxonomy.
If multiple speakers are correctly separated by commas, speakers are correctly added one by one.

If the submission said 'Matt Mullenweg and Mike Little' and the Approve button is hit, then the whole entry would be seen as one speaker.

Proposal 1 (preferred): As most of the videos are English, when the Approve button is hit, replace all ' and ' and '&' with a comma before adding to the Speakers box. So 'Matt Mullenweg and Mike Little' would become 'Matt Mullenweg , Mike Little'

Proposal 2: Show a warning after hitting the Approve button if the speakers contain ' and ' or '&' and indicate a manual action is needed to fill the speakers box

Change History (6)

This ticket was mentioned in Slack in #wptv by casiepa. View the logs.


4 months ago

#2 @webcommsat
4 months ago

Good solutions Pascal. Proposal 2 would allow the moderator to check the names against the talk. If this is a needed step, I would suggest this as a better option. If moderators are checking as they go through a video that the names are correct, then the automation in Proposal 1 would be simpler.

#3 @lorenzof
4 months ago

Hi! Both solutions seem good, but in my opinion the 2nd one is better because it requires a little more attention by the moderator, it's less automated. By the way the difference is thin so both are OK, the important things is that everything works even when the input is in other languages or for some special case, for example people called "And". I know it's rare, but it's a test we can do when choosing the right option.

#4 @dd32
4 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9767:

WordPress.TV: Force multiple speakers to be separated by a comma, strip multiple spaces from the field, and add a placeholder example.

Fixes #5166.

#5 @dd32
4 months ago

[9767] isn't quite what's requested here, but I feel probably achieves the needed goal.

Proposal 1 (preferred): As most of the videos are English, when the Approve button is hit, replace all ' and ' and '&' with a comma before adding to the Speakers box. So 'Matt Mullenweg and Mike Little' would become 'Matt Mullenweg , Mike Little'

This is implemented, but as JS on the upload form, where John & James will be changed to John, James after moving focus away from the field.

the important things is that everything works even when the input is in other languages

I've implemented using & or + as joining, but you're right, this won't work with German John und James which is hopefully less common. If that happens, you'll still have to correct/edit/etc the fields.

or for some special case, for example people called "And"

I've only applied it to a lower-case and so John, And won't be altered, but John and And will result as John, And.
It also requires spaces around the characters, so andrew won't match.

This ticket was mentioned in Slack in #wptv by casiepa. View the logs.


4 months ago

Note: See TracTickets for help on using tickets.