WordPress.org
Get WordPress

Making WordPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#5174 closed defect (bug) (fixed)

Missing lang attribute on download counter template

Reported by: bradleyt's profile bradleyt Owned by: dd32's profile dd32
Milestone: Priority: low
Component: General Keywords:
Cc:

Description

The download counter template is available in all languages. E.g.

​https://es.wordpress.org/download/counter/
​https://fr.wordpress.org/download/counter/

Unlike the rest of the .org network, these download counter pages do not output a lang attribute on the HTML element. This is important for accessibility and SEO reasons.

I think the fix is as simple as making use of language_attributes() in the template.

Change History (3)

#1 @jonoaldersonwp
4 years ago

Seconded.

#2 @dd32
4 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9780:

WordPress.org: Download Counter: Include the language attributes.

Props bradleyt.
Fixes #5174.

#3 @dd32
4 years ago 

$ curl -s https://es.wordpress.org/ | grep 'lang="' | grep html
<html xmlns="http://www.w3.org/1999/xhtml" dir="ltr" lang="es-ES">

$ curl -s https://es.wordpress.org/download/counter/ | grep 'lang="' | grep html
<html lang="es">

Which is "more correct"

Note: See TracTickets for help on using tickets.