WordPress.org

Making WordPress.org

Opened 5 months ago

Last modified 3 months ago

#5175 new enhancement

Plugin Directory: End Support for 'asset' files outside of the assets folder

Reported by: Ipstenu Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords:
Cc:

Description

Per comment by @otto42:

We should probably stop supporting screenshots outside of assets in a going-forward manner. But that's another topic.

This is not terribly complex, however it should come with a time frame. That is, post on make/plugins and then in a month cease support.

  • trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/readme.txt -- needs to be updated to no longer say that assets superceeds tags etc
  • trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/readme/readme.txt - Same.
  • trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php - no longer check for trunk/tags

Change History (8)

#1 @dd32
5 months ago

Removing any public facing mentions of it would be a good first step here.

I have a question around how it would actually work, say Plugin A has been in the directory since 2010, has always used screenshots in their trunk folder. Do those screenshots still work? Do they cease to work when they make their next update? et

#2 @Ipstenu
5 months ago

I would be inclined to just make it stop working, commits or not. Maybe throw up a message for the committers "Your images are not loading because they are not located in the assets folder. Please review [link to post on make./plugins] for details." We have been pushing that for a while.

But. A quick scan says around 16,500 plugins do this with screenshots (that includes some closed one) so maybe that's not a great idea.

Could we put a block on svn uploads of those files to anything outside of assets?

#3 @dd32
5 months ago

Could we put a block on svn uploads of those files to anything outside of assets?

We probably could, allow deletes of screenshots in the trunk folder, but don't allow adding new ones..

#4 @dd32
5 months ago

In 9807:

Plugin Directory: Update the readme example to not mention putting screenshots in the plugin folder.

This also updates the default metadata for the readme.txt, and combines the two different readme's by consistently removing the Installation and Arbitrary sections since they're rarely if ever properly used.

See #5175.

#5 follow-up: @casiepa
5 months ago

Hi @dd32,
I saw your update for https://meta.trac.wordpress.org/changeset/9807
If I remember well, as also in the markup example in that same file, the best way of numbering was to always keep 1.

So maybe consider changing

  1. This is the second screen shot

Into

  1. This is the second screen shot

?

#6 in reply to: ↑ 5 ; follow-up: @dd32
5 months ago

Replying to casiepa:

If I remember well, as also in the markup example in that same file, the best way of numbering was to always keep 1.

So maybe consider changing

  1. This is the second screen shot

Into

  1. This is the second screen shot

Evidently both work fine, and since I don't trust people to know Markdown (no one should have to) I don't really see a need to change that. Using numbered numbers (even though the number is ignored) seems clearer to me, especially given they correspond to numbers in the screenshot filenames.

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.


3 months ago

#8 in reply to: ↑ 6 @casiepa
3 months ago

Replying to dd32:

Evidently both work fine, and since I don't trust people to know Markdown (no one should have to) I don't really see a need to change that. Using numbered numbers (even though the number is ignored) seems clearer to me, especially given they correspond to numbers in the screenshot filenames.

Well, If there are already 10 screenshots and you need to insert one in between the 5th and 6th, you don't need to start renumbering 6-10 to 7-11, but indeed, not sure how many people think of this as markdown.

Note: See TracTickets for help on using tickets.