WordPress.org

Making WordPress.org

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#5194 closed defect (fixed)

unstripped <abbr> tags in topic title after changeset/9802

Reported by: fierevere Owned by: dd32
Milestone: Priority: normal
Component: Support Forums Keywords:
Cc:

Description (last modified by SergeyBiryukov)

Changeset [9802] (related tickets #2018 and #5167)
Allows users/moderators to mark up topics as NSFW, prepending [NSFW] to topic name.

It seems that <abbr> tags are not stripped from page title
Picture:
https://i.imgur.com/loiaEt6.png (from russian forum, title is localized)

Test topic: https://wordpress.org/support/topic/xxx-test/?view=all
(archieved, requires moderator privileges to view)
HTML:

<title>&lt;abbr title=&quot;Not Safe For Work / Mature content&quot;&gt;[NSFW]&lt;/abbr&gt; XXX test &#124; WordPress.org</title>

Additional issue in w.org profile activity (for replies):

Posted a reply to <abbr title=\"Not Safe For Work / Mature content\">[NSFW]</abbr> XXX test, on the site WordPress.org Forums:

Posted a reply to <abbr title=\"Содержимое для взрослых\">[18+]</abbr> XXX, on the site Форумы поддержки:

topic creation is shown correctly:
Created a topic, XXX test, on the site WordPress.org Forums:

Change History (7)

#1 @SergeyBiryukov
5 months ago

  • Description modified (diff)

This ticket was mentioned in Slack in #forums by yui. View the logs.


5 months ago

#3 @dd32
5 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 9817:

Support Forums: NSFW: Dont' output the <abbr> in the <title> tag.

See #2018.
Fixes #5194.

#4 follow-up: @fierevere
5 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
Posted a reply to <abbr title=\"Not Safe For Work / Mature content\">[NSFW]</abbr> XXX test, on the site WordPress.org Forums:
https://meta.trac.wordpress.org/changeset/9817	

22 seconds ago

Thanks for fixing, but
"abbr" is still present in wordpress.org profile Activity, for replies.

#5 in reply to: ↑ 4 @dd32
5 months ago

Replying to fierevere:

"abbr" is still present in wordpress.org profile Activity, for replies.

Apologies, I missed that part of the ticket. Not as easy to remove it from the activity log.. Should probably handle that and #3162 together.

#6 @dd32
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 9824:

Profiles: When notifing profiles.wordpress.org of activity, strip tags and shortcodes from the title and content.

Additionally, remove support forum replies/topics from the activity feeds when they're Archived.

See #2408.
Fixes #3162, #5194.

#7 @fierevere
5 months ago

Great! Thanks!

Note: See TracTickets for help on using tickets.