Making WordPress.org

Opened 4 years ago

Closed 3 months ago

#5324 closed defect (bug) (fixed)

Plugin URLs should 301 to lowercase

Reported by: jonoaldersonwp's profile jonoaldersonwp Owned by: dd32's profile dd32
Milestone: Priority: low
Component: Plugin Directory Keywords: seo
Cc:

Change History (14)

#1 @dd32
4 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 10267:

Plugin Directory: Redirect plugins to their canonical location, avoiding mixed case urls.

Fixes #5324.

#2 @jonoaldersonwp
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Could this preserve URL parameters, please?

#3 @dd32
4 years ago

Which URL parameters?

#4 @jonoaldersonwp
4 years ago

Any/all. I.e., we should redirect the path to lowercase, rather than redirecting the whole request to the canonical.

#5 @dd32
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Okay, there aren't any URL parameters that need keeping here then.

#6 @jonoaldersonwp
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

We rely on various UTM parameters for Google Analytics.

#7 @dd32
4 years ago

Thank you for answering my question.

I don't think we care for keeping the query vars anywhere else, I don't think I'm going to add them here. We don't use UTM links anywhere on WordPress.org, although some plugins and 3rd parties might be setting them.

In other words: I'm leaving this as-is. If 3rd parties set the correct URLs they'll pass through, but I'm not jumping through hoops for it here.

Last edited 4 years ago by dd32 (previous) (diff)

#8 @jonoaldersonwp
4 years ago

We don't need to add them in, we need to not remove them. That's not best practice, and it'll cause us headaches in the future if/when we start to mature our analytics ecosystem.

#9 @dd32
11 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

#10 follow-up: @jonoaldersonwp
11 months ago

  • Description modified (diff)
  • Resolution fixed deleted
  • Status changed from closed to reopened

Looks like we're still strapping parameters.

Version 0, edited 11 months ago by jonoaldersonwp (next)

#11 in reply to: ↑ 10 @dd32
11 months ago

Replying to jonoaldersonwp:

Looks like we're still stripping parameters.

We won't be keeping them, since we don't use them.

This has been as it is for 3 years, so I'm not inclined to say we need to reconsider this.

#12 @jonoaldersonwp
11 months ago

We don't use them today, but that doesn't mean that we won't tomorrow / in the future. That it's been broken for years isn't a good reason not to fix it :D

#13 @dd32
11 months ago

Fixing something that isn't broken isn't a good reason to keep it either.

If we ever end up using them, then we can add the functionality at that time.

Keeping this ticket open forever for something that benefits no-one currently benefits no-one in the long run. It only makes the open ticket count longer.

#14 @dd32
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Retaining query stripping. I'm not investing time in support for a feature we have no intention of using.

Note: See TracTickets for help on using tickets.