Opened 5 years ago
Closed 2 years ago
#5341 closed defect (bug) (fixed)
p2-breathe: remove forced 11px font-size from <code> tags
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Component: | Make (Get Involved) / P2 | Keywords: | needs-patch |
| Cc: |
Description
In p2-breathe theme, there is a very annoying font-size: 11px CSS style applied on each <code> HTML tag.
When applied to headings, it results in quite ugly rendering.
For reference, see this Post on Make/Core: https://make.wordpress.org/core/2020/07/29/miscellaneous-developer-focused-changes-in-wordpress-5-5/
(heading: "Comments: default comment_type value now enforced")
I guess it should be fixed upstream, but I didn't find the p2-breathe GitHub repository.
I found a SVN repository here: https://wpcom-themes.svn.automattic.com/p2-breathe/style.css
The following lines will need to be updated:
/* line 111, css/src/global/_text.scss */
pre {
background: #f1f1f1;
color: #222222;
font-size: 11px; /* Need to be removed */
font-size: 1.1rem;
line-height: 1.4;
margin-bottom: 1.2em;
padding: 1.2em;
overflow: auto;
max-width: 100%;
}
…
pre,
code,
kbd,
tt,
var {
font: 11px Monaco, Consolas, "Andale Mono", "DejaVu Sans Mono", "Courier New", monospace; /* Remove "11px" and replace "font" with "font-family" */
}
Attachments (3)
Change History (9)
#2
@
5 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
[10103] doesn't look good to me, see attached screenshots. Let's use a value that matches the font size of the parent element. .9em seems to be good alternative?
In 10103: