Making WordPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 7 weeks ago

#547 closed enhancement (fixed)

Sessions shortcode doesn't have order=asc

Reported by: andywashere's profile andywashere Owned by: iandunn's profile iandunn
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch
Cc:

Description

The [sessions] shortcode currently does not allow you to sort with an ascending order. Even if you add order=asc, the sessions are still listed in descending order. This means that if you choose orderby=title, sessions are always display in reverse-alphabetical order.

Attachments (1)

meta-547.diff (1.0 KB) - added by ryelle 10 years ago.

Download all attachments as: .zip

Change History (8)

#1 @andywashere
10 years ago

  • Component changed from General to wordcamp.org

#2 @andywashere
10 years ago

  • Type changed from defect to enhancement

@ryelle
10 years ago

#3 @ryelle
10 years ago

meta-547.diff Add 'order' as a shortcode attribute, default to 'desc'.

#4 @iandunn
10 years ago

  • Owner set to iandunn
  • Resolution set to fixed
  • Status changed from new to closed

In 799:

WordCamp Post Types: Add order attribute to sessions shortcode.

Fixes #547
props ryelle

#5 @iandunn
10 years ago

Thanks Kelly :)

This ticket was mentioned in PR #556 on WordPress/wporg-mu-plugins by @adamwood.


7 weeks ago
#6

  • Keywords has-patch added

Fixes #547

I've decided to use absolute positioning so that the H2 can still be present in the markup. No visual changes.

### Testing

The ToC block is used on Documentation and Developer Resources. Using one of those local environments, or sandbox, switch mu-plugins to this branch.

  1. Open pages using the ToC, eg. Code Reference, Block Editor or Optimization
  2. On screens < 1200px wide with the ToC inline, the toggle button should fill the header.
  3. Expand and contract the ToC
  4. Check for regressions on large screens

@renyot commented on PR #556:


7 weeks ago
#7

Followed the testing steps and it worked for me 👍

Note: See TracTickets for help on using tickets.