Opened 4 years ago
Closed 11 months ago
#5475 closed enhancement (fixed)
Set og:image to the existing wp.org/news image on Make posts
Reported by: | claytoncollie | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Make (Get Involved) / P2 | Keywords: | |
Cc: |
Description
In reference to https://meta.trac.wordpress.org/ticket/975
---
This is what it looks like for posts from https://make.wordpress.org/core
This is what it looks like for posts from https://wordpress.org/news
--
Can use the images from [975](https://meta.trac.wordpress.org/ticket/975) to make the default image consistent?
Change History (4)
#1
@
4 years ago
- Component changed from General to Make (Get Involved) / P2
- Summary changed from Set og:image to the existing wp.org/news image on WordPress.org CORE articles to Set og:image to the existing wp.org/news image on Make posts
#3
@
4 years ago
Jetpack was inheriting the "Site Icon" preference from the customizer, I don't think it was actually being used for anything specifically so I've removed it in favour of the default images that the mu-plugin offers.
I've open-sourced that mu-plugin since I was looking into this code and it was in the private repo.
It looks like the Site Icon functionality was only offering higher-resolution non-favicon images:
<link rel="icon" href="https://make.wordpress.org/core/files/2015/11/wordpress-logo-notext-rgb-150x150.png" sizes="32x32" /> <link rel="icon" href="https://make.wordpress.org/core/files/2015/11/wordpress-logo-notext-rgb-300x300.png" sizes="192x192" /> <link rel="apple-touch-icon" href="https://make.wordpress.org/core/files/2015/11/wordpress-logo-notext-rgb-300x300.png" /> <meta name="msapplication-TileImage" content="https://make.wordpress.org/core/files/2015/11/wordpress-logo-notext-rgb-300x300.png" />
It's probably worthwhile migrating that from per-site settings to the global WordPress.org header (which currently only references favicon.ico) rather than just removing these tags outright.
#4
@
11 months ago
- Resolution set to fixed
- Status changed from new to closed
This appears to have been fixed in the intervening three years since this ticket was raised.
The socialsharepreview.com links mentioned in the ticket both currently show the same image, which is also the image chosen for #975.
A new News theme launched a little while ago, and a lot of work has gone into the global header and such, so this was likely covered through a few of those updates.
In 10462: