WordPress.org

Making WordPress.org

Opened 11 months ago

Last modified 4 months ago

#5510 new defect

Translation of the "Topics" string not taken into account in the French handbook

Reported by: jdy68 Owned by:
Milestone: Priority: normal
Component: Handbooks Keywords: has-screenshots needs-patch
Cc:

Attachments (1)

topics-no-translated.png (13.3 KB) - added by jdy68 11 months ago.
An example of no translation

Download all attachments as: .zip

Change History (6)

@jdy68
11 months ago

An example of no translation

#1 @audrasjb
11 months ago

  • Keywords has-screenshots needs-patch added

Thanks for opening this ticket @jdy68 !

Yes, that's an issue, and I guess that file is not a problem by itself, but more the text-domain of the related plugin: table-of-contents-lite

It should be changed to be consistent with the related wporg text domain.
https://meta.svn.wordpress.org/sites/trunk/wordpress.org/public_html/wp-content/plugins/support-helphub/inc/table-of-contents-lite/table-of-contents-lite.php

Cheers,
Jb

#2 follow-up: @dd32
11 months ago

The problem is that the Support Forums localisation isn't loaded on P2 Handbook pages.

The handbook plugin pulls in the HelpHub TOC code, but doesn't load the required textdomains for it.

I recently noticed this, but didn't click that handbooks were in use on non-support localised sites ('duh, of course they are!)

Changing the localisation to wporg won't work as intended, but it might be worth just duplicating some of the TOC code between them, or allowing for a translated string to be passed to it.. or just loading the right textdomain..

#3 in reply to: ↑ 2 @audrasjb
11 months ago

Replying to dd32:

Changing the localisation to wporg won't work as intended, but it might be worth just duplicating some of the TOC code between them, or allowing for a translated string to be passed to it.. or just loading the right textdomain..

Ah yes, by wporg, I meant use a the correct/related wporg-like text-domain :)
Is this plugin available in the repository? Maybe we can also translate it directly?

#4 @audrasjb
11 months ago

If the plugin is not available anymore or has been modified, then it's probably better to move the string to the theme, or something similar?

#5 @coffee2code
4 months ago

The handbook plugin pulls in the HelpHub TOC code, but doesn't load the required textdomains for it.

Just to be clear, the Handbooks plugin implementation of the TOC code predates the HelpHub implementation by 5 years.

As far as text for translation goes, the untranslated words from the referenced handbook page are from the Handbooks plugin. Most prominently:

  • "Topics" (src)
  • "Top ↑" (src)
  • "Watch" (from the post actions dropdown) (src)

The textdomain used in the plugin is wporg, which was chosen many years ago though ideally it should probably be something unique like wporg-handbook. I'm not sure if changing the textdomain would invalidate existing translations. Either way, I don't know where the translations for .org plugins or themes are, or if they're even exposed for translators if they aren't explicitly listed in the Translate Meta projects listing.

In short, the handbook strings are, and have been, coded for translation in the plugin. I'm happy to make any change so they actually appear on the page translated, but I don't know what's needed.

Note: See TracTickets for help on using tickets.