Making WordPress.org

Changes between Initial Version and Version 1 of Ticket #5513, comment 5


Ignore:
Timestamp:
11/18/2020 01:28:17 AM (3 years ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5513, comment 5

    initial v1  
    1 Just noting that to remain GPL compliant either the source files need to be bundled, or it's obvious where to find the non-built versions.. I haven't looked at the plugin, but I'm just noting that here since it's common for JS plugins to not include the human readable source or make it obvious where to find it..
     1Just noting that to remain plugin-directory compliant / GPL compliant either the source files need to be bundled, or it's obvious where to find the non-built versions.. I haven't looked at the plugin, but I'm just noting that here since it's common for JS plugins to not include the human readable source or make it obvious where to find it..
    22
    33Looking at the minified JS here, using regular expressions makes it very hard to match, as it's hard for PHP to know that the call to `f()` here is a `__()` and is within a `registerBlockType()` call: `var d=wp.blocks.registerBlockType,f=wp.i18n.__, ..... d("tainacan/carousel-collections-list",{title:f("Tainacan Collections Carousel","tainacan"),`