Making WordPress.org

Opened 3 years ago

Closed 19 months ago

Last modified 19 months ago

#5636 closed enhancement (fixed)

Retain original plugin upload zips after status change

Reported by: tellyworth's profile tellyworth Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-patch
Cc:

Description

Currently, the initial plugin zip that is uploaded for a newly submitted plugin is deleted as soon as the plugin is approved and a svn repo is created. This occasionally causes a problem because there are circumstances when it would be useful to refer to the old zip upload, both for approved plugins and for those that wind up with a different status.

Instead of deleting the attachment on status change, I'd suggest we schedule deletion via a cron job:

  • 30 days after changing to a rejected/deleted status; or
  • 12 months after changing to a published status.

Change History (4)

#1 @dd32
3 years ago

12 months after changing to a published status.

This seems like a long time to hold a zip for a published plugin.

I'm thinking maybe something shorter, like, 30 days after initial release is committed? Maybe keeping the ZIP around for a maximum of 12 months otherwise? (Such as if the author never comes back to commit a release)

User Submits Plugin X:

  • Reject: Delete ZIP after 30 days
  • Approve:
    • Keep ZIP for 12 months
    • Upon first successful plugin commit/release, Delete ZIP after 30 days

This ticket was mentioned in PR #106 on WordPress/wordpress.org by @dd32.


19 months ago
#2

  • Keywords has-patch added

#3 @dd32
19 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 12175:

Plugin Directory: Don't delete submitted ZIP files immediately upon approval/rejection, and instead delete them x days afterwards.

This provides some room for re-reviewing recently-rejected or recently-approved plugins when required.

Closes https://github.com/WordPress/wordpress.org/pull/106.
Fixes #5636.

#4 @dd32
19 months ago

In 12190:

Plugin Directory: Don't delete submitted ZIP files immediately upon approval/rejection, and instead delete them x days afterwards.

Adding file missed in [12175].

See #5636.

Note: See TracTickets for help on using tickets.