Making WordPress.org

Changes between Version 1 and Version 2 of Ticket #5645, comment 2


Ignore:
Timestamp:
03/02/2021 07:36:45 AM (4 years ago)
Author:
rumperuu
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5645, comment 2

    v1 v2  
    2222> As part of that, a few of us discussed if disabling plugin releases from trunk entirely would be viable, #5484 is a step towards that.
    2323
    24 I think allowing releases from `trunk/` where ‘Stable Tag’ is either ‘trunk’ or nonexistent should be fine (and disabling it would presumably break those projects you mentioned that rely on the behaviour), but having it fallback to `trunk/` when it can't find `tags/stable_tag/` is a footgun waiting to happen, especially as it is currently silent. I would expect a non-`trunk/` stable tag that did not have a matching folder in `tags/` to be considered an error and the last-known-good version to be reverted to.
     24I think allowing releases from `trunk/` where ‘Stable Tag’ is either ‘trunk’ or nonexistent should be fine (and disabling it would presumably break those projects you mentioned that rely on the behaviour), but having it fallback to `trunk/` when it can't find `tags/stable_tag/` is a footgun waiting to happen, especially as it is currently silent. I would expect a non-‘trunk’ stable tag that did not have a matching folder in `tags/` to be considered an error and the last-known-good version to be reverted to.
    2525 
    2626> Another thing worth noting, is that since Github is your primary development platform, syncing every commit to plugins.svn might not be needed, and partially lead to this situation. Personally I use the [https://github.com/10up/action-wordpress-plugin-deploy 10up Github action] which deploys any ''releases'' I tag on Github to be pushed over to plugins.svn instead.