Making WordPress.org

Opened 4 years ago

Closed 4 years ago

#5650 closed task (blessed) (fixed)

New Core committers

Reported by: desrosj's profile desrosj Owned by: tellyworth's profile tellyworth
Milestone: Priority: normal
Component: Communication (Matrix, Slack, IRC) Keywords: has-patch
Cc:

Description

@davidbaumwald and @williampatton were approved for commit and theme commit access respectively.

Their labels on Trac and announce privileges in Slack need to be updated.

Attachments (1)

5650.diff (2.0 KB) - added by desrosj 4 years ago.

Download all attachments as: .zip

Change History (6)

@desrosj
4 years ago

#1 @desrosj
4 years ago

I believe the other steps in the "Tasks to add a committer" list have been completed. @dd32 can you confirm?

#2 @dd32
4 years ago

  • Owner set to tellyworth
  • Status changed from new to assigned

Committers don't need to be given announce for #core[-*] as being listed in the committer array is enough.

I think the items in this ticket are the only things left, assuming passwords, etc have been discussed :) cc @tellyworth

#3 follow-up: @desrosj
4 years ago

Committers don't need to be given announce for #core[-*] as being listed in the committer array is enough.

I believe I removed David from the #core room for that reason in the patch. I left William on the list for the theme review room because that room does not merge committers into the list. Though, it may make sense to merge just the theme committers into that list. But that's probably a discussion for another ticket.

They have been taken through the new committer documentation and given the breakdown from @chanthaboune. I'll also be pairing with them as a buddy for their first few commits.

#4 in reply to: ↑ 3 @dd32
4 years ago

Replying to desrosj:

Committers don't need to be given announce for #core[-*] as being listed in the committer array is enough.

I believe I removed David from the #core room for that reason in the patch. I left William on the list for the theme review room because that room does not merge committers into the list.

:facepalm: I misread the patch diff :D

#5 @dd32
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 10788:

Committers: Mark the new committers as committers, and give them a proper trac title.

Props desrosj.
Fixes #5650.

Note: See TracTickets for help on using tickets.