Making WordPress.org

Opened 10 months ago

Last modified 10 months ago

#5665 new defect

Add support for comma separated revision numbers on Make blogs

Reported by: desrosj Owned by:
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords:


On Trac, specifying a commit range with commas and/or hyphens is supported:

The same format is supported on Make blogs, but it seems that commas do not get matched.

I noticed this while rereading this post before drafting a followup (see the last paragraph before the "Known next steps (updated)" heading 2/3 the way down).

I also tested with only commas, but that also does not work. So using , combined with - can be ruled out as the reason.

Change History (1)

#1 @dd32
10 months ago

The functionality you're referring to is the P2 Hovercards, which only support a singular commit/ticket reference. The [] format only supports linking to core.trac as well, unlike the r1234-$trac format which can specify which trac/svn the commit relates to.

Unfortunately the existing code is in a private repo, but there's an outdated example of it in the plugin being used: https://github.com/Automattic/p2-hovercards/blob/master/examples.php That uses svn_log() where as we're using a Trac endpoint instead.

I might see if it's possible to open-source it, or at least open-source the custom hovercards.

Note: See TracTickets for help on using tickets.