WordPress.org

Making WordPress.org

Opened 4 months ago

Last modified 4 months ago

#5749 new defect

GitHub integration: Showing "All checks pass" on failing PR

Reported by: ryelle Owned by:
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

The issue was seen on https://core.trac.wordpress.org/ticket/53246 — the action checks failed, but the UI in trac reported the PR as "All checks pass".

I haven't investigated to see if this is working on other tickets.

Attachments (1)

Screen Shot 2021-05-25 at 3.04.35 PM.png (28.0 KB) - added by ryelle 4 months ago.

Download all attachments as: .zip

Change History (2)

#1 @dd32
4 months ago

(This is a note for myself, and any others who look at it, mostly thinking out loud)

Before opening the trac ticket up, I looked at the cached data:

"mergeable_state":"unknown","check_runs":[],"reviews":[],

After loading the ticket, I saw

✅ All checks pass, GitHub Actions running

And I can now see the cached data is updated to be

"mergeable_state":"blocked","check_runs":{"GitHub Actions":"in_progress"},"reviews":[],

At a guess, I'm thinking an API request to GitHub may have timed out, resulting in no check_runs being cached, resulting in an all-checks-pass?

Having no check_runs is expected for some PRs, for example to WordPress/wordpress.org, but not for core trac. But having All checks pass without check_runs doesn't make sense, until you consider that for meta it shows whether it can be merged or not (even tho we don't merge PRs on GitHub)

Note: See TracTickets for help on using tickets.