Making WordPress.org

Opened 6 years ago

Closed 3 years ago

Last modified 11 months ago

#577 closed defect (fixed)

credits API should return the correct version

Reported by: markoheijnen Owned by: coffee2code
Milestone: Priority: normal
Component: API Keywords: has-patch commit


You could request data for a version that the API doesn't support. It then fallsback to WP_CORE_STABLE_BRANCH except the requested version is still displayed. We should then return the actual version so you can that validate your request.

Also any way we could provide data for versions older then 3.2?

Attachments (1)

577.diff (594 bytes) - added by markoheijnen 6 years ago.

Download all attachments as: .zip

Change History (8)

6 years ago

#1 @markoheijnen
5 years ago

Any feedback on this?

#2 in reply to: ↑ description @ramiy
4 years ago

Replying to markoheijnen:

Also any way we could provide data for versions older then 3.2?

Just installed wp3.2, wp31 and wp30 to create the WP_31_Credits and WP_30_Credits classes for the API.

But it seems like credits.php was added only in 3.2, this is why the API supports only 3.2+

If you have this data for older versions, I can write the code.

I need:

  • a list of users:
    • Project Leaders
    • Extended Core Team
    • Recent Rockstars
    • Core Contributors
  • a list of external libraries
Last edited 4 years ago by ramiy (previous) (diff)

#3 @ramiy
4 years ago

The full list of "Core Contributors" can be found in blog release post:

3.2: https://wordpress.org/news/2011/07/gershwin/
3.1: https://wordpress.org/news/2011/02/threeone/
3.0: https://wordpress.org/news/2010/06/thelonious/

We can retrieve the "external libraries" using the change log of the next version.

#4 @SergeyBiryukov
4 years ago

  • Keywords commit added

577.diff looks good to me.

#5 @coffee2code
3 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 5133:

Credits API: Return 'version' value that matches the data being returned.

For invalid version requests (e.g. something pre-3.2 or post-WP_CORE_STABLE_BRANCH), the Credits API returns data for WP_CORE_STABLE_BRANCH. In such cases the 'version' value in the response was the invalid version being requested.

The returned 'version' should instead reflect the version that matches the data. API consumers can compare their requested version to the response version to see if the fallback (current stable) is being returned.

Props markoheijnen.
Fixes #577.

This ticket was mentioned in Slack in #meta by sergey. View the logs.

11 months ago

#7 in reply to: ↑ description @SergeyBiryukov
11 months ago

Replying to markoheijnen:

Also any way we could provide data for versions older then 3.2?

Follow-up: #4697

Note: See TracTickets for help on using tickets.