WordPress.org

Making WordPress.org

Opened 6 years ago

Closed 4 years ago

#58 closed enhancement (fixed)

Adding IE6 Support for Browse Happy

Reported by: aphillips8 Owned by: coffee2code
Milestone: Priority: low
Component: Browse Happy Keywords: has-patch
Cc:

Description

It's important for the site to display in IE6 because it's mostly aimed at people with outdated browsers.

I've added the support on GitHub (see below) and was told in the forums to link a ticket to it.

Pull Request: https://github.com/WordPress/browsehappy/pull/8

Thanks,
Anna

Attachments (1)

browsehappy_ie6_support.patch (11.4 KB) - added by aphillips8 5 years ago.
Adding IE6 support - Encoding apostrophes. Serving stylesheet, Modernizr and webfonts to IE6. Versioning stylesheet. Applying PNG fix to IE6 only. Fixing layout bugs in IE6.

Download all attachments as: .zip

Change History (14)

#1 @samuelsidler
6 years ago

  • Owner set to nacin
  • Status changed from new to assigned

#2 @aphillips8
6 years ago

Hi, any updates on this?

Thanks!
Anna

#3 @blobaugh
5 years ago

Before adding this in I think it is important to ask why? IE 6 is really old. It was released 12 years ago and the last patch was 6 years ago (http://en.wikipedia.org/wiki/Internet_Explorer_6).

What percentage of the internet is still running IE 6? If it is less than 1% I contend that it is not worth going backwards for.

#4 @aphillips8
5 years ago

A few notes:

  1. I've already made all the code changes to add IE6 support - I just need someone to merge it in.
  1. People get linked to the site because they have an old browser. People with old browsers are the target audience.

Also I opened this ticket almost a year ago when there were slightly more IE6 users.

If you have the authority to merge my pull request it would be greatly appreciated.

Thanks!
Anna

#5 @Otto42
5 years ago

For reference, approximately 8% of all visitors to browsehappy.com are reported as IE 6 users.

IE versions less than 6 is under 0.05%, and can thus be ignored, but 8% seems significant enough to handle properly for that site in particular, if the change is not severe.

Other relevant information:

  • IE browsers comprise 80% of the visits, and of those visits only, IE 6 accounts for 10% of that.
  • Most common browser: IE 8, which is just under half of all visitors.

Source: Google Analytics. All numbers above rounded for simplicity.

Also, a patch file in this ticket would be a lot easier for us to merge than something from github. Github is a handy mirror for those wanting to work with it, but the source files that are being used actually live in SVN, here:
http://meta.svn.wordpress.org/sites/trunk/browsehappy.com/public_html/

#6 @blobaugh
5 years ago

Thanks for the numbers @Otto42! I did not realize it was so high still. Maybe it makes sense that browsehappy.com would have higher numbers for the older browsers than elsewhere :)

@aphillips8
5 years ago

Adding IE6 support - Encoding apostrophes. Serving stylesheet, Modernizr and webfonts to IE6. Versioning stylesheet. Applying PNG fix to IE6 only. Fixing layout bugs in IE6.

#7 @aphillips8
5 years ago

Hello, thank you for your help. I couldn't find the SVN repo for Browse Happy so ended up over at GitHub. I've added a patch to this ticket.

#8 @aphillips8
5 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #meta-devhub by coffee2code. View the logs.


5 years ago

This ticket was mentioned in Slack in #meta-devhub by coffee2code. View the logs.


5 years ago

#11 @samuelsidler
4 years ago

  • Owner nacin deleted

Let's be realistic. :)

#12 @coffee2code
4 years ago

  • Owner set to coffee2code
  • Status changed from assigned to accepted

#13 @coffee2code
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in [2594] (and on GitHub).

Thanks for the contribution and your patience!

Note: See TracTickets for help on using tickets.