Making WordPress.org

Opened 3 years ago

Closed 21 months ago

Last modified 21 months ago

#5834 closed defect (bug) (fixed)

Adjust themes screenshot in the themes directory

Reported by: kafleg's profile kafleg Owned by: dufresnesteven's profile dufresnesteven
Milestone: Priority: normal
Component: Theme Directory Keywords: has-patch
Cc:

Description

At first, check this link. You can see many themes with different sizes of screenshots. The reason behind this is, theme authors submitted themes with invalid screenshot sizes.

As per the theme guidelines, the valid/proper size of the screenshot should be in a 4:3 ratio. Many theme authors follow this and submit themes with proper screenshot size. However, many authors submit /update themes with improper size. Because of that, the themes directory listing page looks bad.

Theme reviewers used to check screenshot size by manual process. But after the new version of the Theme Check plugin is added, it's handled by the plugin itself. But, the Theme Check plugin won't work for child themes. And still, there is a chance that the theme author submits themes with an invalid screenshot size.

The current themes screenshot requirement is applied to make the themes page good. There are no other reasons for this. If the theme directory can be updated to display the correct size, the requirement is not needed.

Attachments (5)

5834.patch (486 bytes) - added by dufresnesteven 3 years ago.
Screenshot on 2021-08-03 at 09-28-12.png (142.2 KB) - added by dufresnesteven 3 years ago.
Screenshot on 2021-08-03 at 09-28-29.png (1.4 MB) - added by dufresnesteven 3 years ago.
5834.diff (816 bytes) - added by dufresnesteven 2 years ago.
Don't use aspect-ratio but instead its generated polyfill which supports more browsers.
Screen Shot 2022-03-31 at 1.39.45 PM.png (596.5 KB) - added by dufresnesteven 2 years ago.
With the latest patch applied.

Change History (15)

#1 @dufresnesteven
3 years ago

The current themes screenshot requirement is applied to make the themes page good. There are no other reasons for this. If the theme directory can be updated to display the correct size, the requirement is not needed.

I think it's better to remove this as a requirement and update .org.

@dufresnesteven
3 years ago

#2 @poena
2 years ago

  • Keywords has-patch added; needs-patch removed

#3 @poena
2 years ago

I have tested the patch and it works well as long as support for IE11 is not expected.
IE11 does not have support for aspect-ratio.

This ticket was mentioned in Slack in #meta by poena. View the logs.


2 years ago

#5 @dd32
2 years ago

aspect-ratio is only supported in browsers as of January 2021, there do exist some polyfills that might be worth looking into as an option here too.

Before a restriction is lifted on dotorg though, some confirmation that no fixes are required within core for mis-sized images would be good (ie. on the Install themes page, not necessarily the theme listing page)

#6 @poena
2 years ago

You are right, I think there was one view that was not double checked,
the image in the customizer preview is not displayed correctly.

#7 @poena
2 years ago

I'd consider this customizer view low priority but I put the ticket in the 5.9 milestone.
https://core.trac.wordpress.org/ticket/54188

@dufresnesteven
2 years ago

Don't use aspect-ratio but instead its generated polyfill which supports more browsers.

@dufresnesteven
2 years ago

With the latest patch applied.

#8 @dufresnesteven
21 months ago

  • Owner set to dufresnesteven
  • Resolution set to fixed
  • Status changed from new to closed

In 11876:

wporg-themes: Adjust themes screenshot in the themes directory.

Props kafleg, poena, dd32.
Fixes #5834.

#9 @dufresnesteven
21 months ago

Hmm... Changes were working in Sandbox but not on the live site. Investigating...

#10 @dufresnesteven
21 months ago

In 11877:

wporg-themes: Break theme css cache.

See: #5834.

Note: See TracTickets for help on using tickets.