Opened 3 years ago

Closed 5 months ago

#5896 closed defect (bug) (fixed)

Non-English language in the theme check result

Reported by: kafleg's profile kafleg Owned by: dd32's profile dd32
Milestone: Priority: normal
Component: Theme Directory Keywords: needs-testing


Theme check results in themes Trac ticket have non-English recommended message. I noticed this for the first time.

Here is the theme ticket link for reference.

I checked this theme on my local installation with the theme check plugin(GitHub version) too. But there is no message in a different language.

Change History (6)

#1 @dd32
3 years ago

This is because the theme upload was processed through a localised site, for example (I'm not sure which locale this one is).

There's two options:

a) Disable translations for Theme Check on
b) Live with translated messages

Unfortunately I don't think we can really have both here, unless we were to run theme-check twice, once to display to the user, once to post to Trac.

#2 @dd32
3 years ago

  • Component changed from Trac to Theme Directory

#3 @dd32
3 years ago

This can also be seen in the Slack logging of uploads, eg:

#4 @dufresnesteven
22 months ago

This is a weird spot to be in. @kafleg, how big of an issue is this for reviews? Do reviewers actively use the theme check results as cues during the review? If so, since reviews are officially done in English, I vote that we turn off translations.

#5 @kafleg
22 months ago

Hi @dufresnesteven

Reviewers use the theme check plugin actively while reviewing the theme. And we can turn off the local language(translated language) in the trac ticket message. We can make it English even if that is submitted from localised site.

I agree to turn off translations :)

#6 @dd32
5 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 13100:

Theme Directory: Always run theme check in English, as reviews take place in english.

Fixes #5896.

Note: See TracTickets for help on using tickets.