Add a 'needs-e2e-tests' keyword to trac

[talldanwp]

Trac currently has a very specific 'needs-unit-tests' keyword, and it could be useful to have the same to encourage end to end tests.

The simplest solution might be to add a 'needs-e2e-tests' keyword, but also open to other ideas.

Trac does seem to have a lot of keywords, and I also noticed there are requests for more (#5634), so an alternative would be to rename 'needs-unit-tests' a more generic 'needs-tests'.

[dd32]

I like needs-tests better than two separate labels, but I can see it being confused with needs-testing.

Isn't an e2e just a visual unit test though? ;)

Perhaps needs-testing would work with needs-tests better if the former was renamed to testing-required too?

Adding keywords isn't an issue (other than the list growing), renaming them isn't as straight forward though, as it requires a string-replace on the Trac DB.

[talldanwp]

I dropped a message about this ticket in the core-test slack channel, so hopefully there will be some extra opinions added soon. Maybe we could add a '3rd-opinion' keyword too? ;)

[dd32]

Maybe we could add a '3rd-opinion' keyword too? ;)

Huh, you don't see that option? /s

[SergeyBiryukov]

Replying to dd32:

Perhaps needs-testing would work with needs-tests better if the former was renamed to testing-required too?

Just a few more options to consider:

• needs-unit-tests → needs-automated-tests
• needs-testing → needs-manual-testing