Opened 3 years ago

Closed 6 months ago

#5975 closed enhancement (fixed)

Plugin Directory: Show name of committer being removed in JavaScript confirmation.

Reported by: peterwilsoncc's profile peterwilsoncc Owned by: dd32's profile dd32
Milestone: Priority: high
Component: Plugin Directory Keywords:


When removing a committer from a plugin, a JavaScript confirmation is shown with the text generic text "Are you sure you would like to remove this committer?" (or similar).

To avoid mistakes, it would be helpful if the confirmation included the committers name and/or username. Something along the lines of "Are you sure you would like to remove @peterwilsoncc's commit access?"

An alternative may be to highlight the committer's name in yellow while the confirmation dialog is open.

Change History (2)

#1 @dd32
3 years ago

  • Priority changed from normal to high

Every confirmation message on the plugin-author facing options screen needs better confirmations (That default to aborting the process).

We'd be better off migrating all the destructive actions to an inline modal confirming the action with a full description. (I consider adding/removing committers to be potentially destructive)

I'm shifting this to priority:high because it'll make plugin reviewers lives easier if they don't have to fix problems plugin authors accidentally cause due to bad author actions/confirmations, and accidentally removing/adding the wrong people to be a committer could have all sorts of unforeseen issues.

#2 @dd32
6 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 13128:

Plugin Directory: Include the name of the user being removed as a committer / support rep.

Fixes #5975.

Note: See TracTickets for help on using tickets.