Opened 3 years ago

Closed 2 years ago

#6031 closed defect (bug) (fixed)

Improper flag as first submission

Reported by: topher1kenobe's profile topher1kenobe Owned by:
Milestone: Priority: normal
Component: Photo Directory Keywords:


post_id 1714 has been flagged as first submission, but the submitter already has one rejected image. I don't know how we should change it, but that doesn't seem right.

Change History (3)

#1 @coffee2code
3 years ago

Technically "First submission" implies this is potentially their first published photo (and thus they currently have no published photos). Even in having a rejection, they still haven't had a photo published.

I do intend to add a "Has rejection(s)" flag (maybe orange for 1-3 rejections, red if 4+ or if they have rejections but no approvals).

Would having both "First submission" and "Has rejection" flags appear for the photo in question be sufficient and clear? Or should the flag be renamed to something like "No published photos"?

#2 @topher1kenobe
3 years ago

I like No Published Photos, but I also like the "Has rejection", possibly even with a number. Any one of us could have a couple rejections due to focus, but if someone has 30 rejections I want to know why.

#3 @coffee2code
2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [18334-dotorg] (on 2022-01-21):

Photo Directory, Moderation: Rename flag from "First Submission" to "No Published Posts".

Props topher1kenobe.
Fixes #6031.

In [18336-dotorg], also implemented the "Has Rejections (%d)" flag that includes a count of the number of rejections.

Photo Directory, Moderation: Add flag to indicate past rejections.

  • Doesn't count submission errors since a photo was never received.
  • Has a threshold constant to determine at which point the number of rejections warrant being an alert as opposed to a warning.

Currently less than 5 rejections warrant a warning (orange flag). 5+ rejections warrant an alert (red flag). We can adjust the threshold if necessary.

Also, as of [18351-dotorg]:

Photo Directory, Moderation: If a user has any number of rejections but no approvals, then flag their rejections as an alert.

Note: See TracTickets for help on using tickets.