Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6041 closed enhancement (fixed)

Make improvements to the WP.org Openverse site

Reported by: dhruvkb's profile dhruvkb Owned by: iandunn's profile iandunn
Milestone: Priority: highest omg bbq
Component: WordPress.org Site Keywords: has-patch
Cc:

Description

This PR (https://github.com/WordPress/wordpress.org/pull/51)

  • changes supplied path to lowercase to prevent 404 on case variations of https://wordpress.org/openverse
  • uses a fixed value of --header-height to make the iframe occupy 100vh - header height
  • adds functionality for sending meta-data from iframe to the parent window
  • updates test page (also adds tips for certain fields)
  • updates README.md and .wp-env.json to setup a dev environment

Change History (4)

This ticket was mentioned in PR #51 on WordPress/wordpress.org by dhruvkb.


2 years ago
#1

This PR

  • changes supplied path to lowercase to prevent 404 on case variations of https://wordpress.org/openverse
  • uses a fixed value of --header-height to make the iframe occupy 100vh - header height
  • adds functionality for sending meta-data from iframe to the parent window
  • updates test page (also adds tips for certain fields)
  • updates README.md and .wp-env.json to setup a dev environment

Closes https://meta.trac.wordpress.org/ticket/6041

#2 @iandunn
2 years ago

  • Owner set to iandunn
  • Resolution set to fixed
  • Status changed from new to closed

In 11466:

Openverse: Fix 404s and embed height, send frame meta data

  • changes supplied path to lowercase to prevent 404 on case variations of https://wordpress.org/openverse
  • uses a fixed value of --header-height to make the iframe occupy 100vh - header height
  • adds functionality for sending meta-data from iframe to the parent window
  • updates test page (also adds tips for certain fields)
  • updates README.md and .wp-env.json to setup a dev environment

Props dhruvkb, sarayourfriend, zackkrida
Fixes #6041

iandunn commented on PR #51:


2 years ago
#3

Merged in https://meta.trac.wordpress.org/changeset/11466, with Zack's px suggestion included

dhruvkb commented on PR #51:


2 years ago
#4

Thanks @iandunn!

Note: See TracTickets for help on using tickets.