Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6111 closed enhancement (fixed)

Unused or Unwanted (blank) css and also extra colon(:) in css background property

Reported by: kajalgohel's profile kajalgohel Owned by: dd32's profile dd32
Milestone: Priority: lowest
Component: Developer Hub Keywords: has-patch
Cc:

Description

In the wordpress.org theme directory, the unwanted blank class in main.scss file which has not included any property. It is totally blank. and in the background property the colon(:) is extra written.we should remove this for better css coding standard.

Attachments (2)

#6111.patch (2.3 KB) - added by kajalgohel 2 years ago.
#6111.2.patch (2.4 KB) - added by kajalgohel 2 years ago.
change unknown property "text-alignment" to "text-align"

Download all attachments as: .zip

Change History (8)

@kajalgohel
2 years ago

#1 @kajalgohel
2 years ago

There is also Unknown property of css text-alignment in same file. We should replace with text-align. Because the alignment property is wrong and is not working for text alignment.

@kajalgohel
2 years ago

change unknown property "text-alignment" to "text-align"

#2 @dd32
2 years ago

  • Component changed from WordPress.org Site to Developer Hub
  • Priority changed from normal to lowest

The patch changes some invalid CSS to be valid CSS, but should those properties actually be there? ie. will fixing the bug introduce a bug?

The Handbook comment should have / in it I think.

The empty rules aren't exactly a problem though..

#3 @dd32
2 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 11657:

Developer: CSS Cleanup.

Props kajalgohel.
Fixes #6111.

#4 @dd32
2 years ago

In 11658:

Developer: Revert [11657].

See #6111.

#5 @dd32
2 years ago

background-color:: was handled in [11574]

#6 @dd32
2 years ago

In 11659:

Developer: SASS Cleanup.

Props kajalgohel.
Fixes #6111.

Note: See TracTickets for help on using tickets.