Making WordPress.org

Opened 2 years ago

Last modified 2 years ago

#6117 new defect (bug)

In WordPress Plugin Directory has plugin active tab issue in responsive

Reported by: multidots1896's profile multidots1896 Owned by:
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-screenshots needs-refresh
Cc:

Description

In WordPress Plugin Directory has plugin active tab issue in responsive.

Attachments (5)

6117.patch (141.9 KB) - added by multidots1896 2 years ago.
Added patch for active tab not looks proper.
screenshot.png (177.8 KB) - added by multidots1896 2 years ago.
added screenshot
modify-screenshot.png (183.9 KB) - added by multidots1896 2 years ago.
added screenshot after modified
6117.2.patch (142.1 KB) - added by multidots1896 2 years ago.
added patch
6117.3.patch (1.7 KB) - added by multidots1896 2 years ago.
Applied Patch and added css in scss file

Download all attachments as: .zip

Change History (9)

@multidots1896
2 years ago

Added patch for active tab not looks proper.

@multidots1896
2 years ago

added screenshot

@multidots1896
2 years ago

added screenshot after modified

#1 follow-up: @dd32
2 years ago

  • Keywords needs-refresh added; has-patch removed

@multidots1896 Can you attach a diff of the non-minified files?

#2 in reply to: ↑ 1 @multidots1896
2 years ago

hi @dd32
Here I have applied patch but already i have getting minified css in style.css file
/Users/minaldiwan/Local Sites/meta/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/css/

and added below css in patch

.type-plugin span#advanced.displayed~.tabs li#tablink-advanced,.type-plugin span#developers:target~.tabs li#tablink-developers,.type-plugin span#installation:target~.tabs li#tablink-installation,.type-plugin span#reviews:not(:target)~span#installation:not(:target)~span#developers:not(:target)~span#advanced:not(.displayed)~.tabs li#tablink-description,.type-plugin span#reviews:target~.tabs li#tablink-reviews{border:none;border-bottom:0;padding-bottom:2px;background:#0285b9}.type-plugin span#advanced.displayed~.tabs li#tablink-advanced a, .type-plugin span#developers:target~.tabs li#tablink-developers a, .type-plugin span#installation:target~.tabs li#tablink-installation a, .type-plugin span#reviews:not(:target)~span#installation:not(:target)~span#developers:not(:target)~span#advanced:not(.displayed)~.tabs li#tablink-description a, .type-plugin span#reviews:target~.tabs li#tablink-reviews a {background: #0285b9;color: #fff;}

Thanks

@multidots1896
2 years ago

added patch

#3 follow-up: @dd32
2 years ago

@multidots1896 Please don't include the minified style.css in the patch file.

You'll need to edit the SCSS files in:
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/client

To build that into the final minified CSS, you can follow the instructions in:
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/README.md

When submitting the .diff file, generate it for the client folder, and any other files modified, except the style directory. It's okay if the diff includes the minified files, but if the rest aren't included, the patch will be ignored.

@multidots1896
2 years ago

Applied Patch and added css in scss file

#4 in reply to: ↑ 3 @multidots1896
2 years ago

hi @dd32
I have added patch and modify scss file as given following path
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/client

Thanks

Note: See TracTickets for help on using tickets.